Fix/492 vesting paused wrong error#519
Merged
Austinaminu2 merged 2 commits intoApr 27, 2026
Merged
Conversation
…n not paused Closes Austinaminu2#493 unpause() was returning Err(VestingError::Common(CommonError::NotInitialized)) when the schedule was not paused. This is misleading: callers receiving NotInitialized would assume the contract was never set up, when the actual problem is simply that the schedule is not in a paused state. Replace with Err(VestingError::NotPaused), which is the dedicated variant (error code 10) defined for exactly this purpose. Also fix pre-existing syntax bugs in the test module: - Duplicate mod test/mod tests declaration collapsed to a single mod tests - Broken get_config duplicate definition (incomplete first copy removed) - Nested function definitions in test_double_cancel_fails and test_claim_after_cancel_fails separated into proper top-level tests Add test: - test_unpause_when_not_paused_returns_not_paused: verifies unpause() returns VestingError::NotPaused on an active (non-paused) schedule.
…laim(), and pause() Closes Austinaminu2#492 Three functions were returning Err(VestingError::Common(CommonError::Unauthorized)) when the schedule was paused. CommonError::Unauthorized means the caller lacks permission, but a paused schedule is a state condition, not an authorization failure. This forces integrators to inspect raw error codes to distinguish the two cases, making error handling fragile. Replace all three occurrences with Err(VestingError::Paused), which is the dedicated variant (error code 9) defined for exactly this purpose: - claim(): paused check now returns VestingError::Paused - cancel_and_claim(): paused check now returns VestingError::Paused - pause(): already-paused check now returns VestingError::Paused Add tests: - test_cancel_and_claim_while_paused_returns_paused: verifies cancel_and_claim() returns VestingError::Paused when the schedule is paused. - test_pause_when_already_paused_returns_paused: verifies pause() returns VestingError::Paused when called on an already-paused schedule.
|
@observerr411 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Provide a clear and concise summary of the changes made in this PR]
closes #492
Related issue
[Link to the issue, e.g., #123]
Related Issue
[Link to the issue this PR addresses, e.g. Closes #123]
Type of Change
Testing
Tests Performed
[Describe the tests you ran to verify your changes. Include:
Test Results
[All tests should pass. Include any test output or screenshots if relevant]
Checklist
cargo fmtto format the codecargo clippyto lint the codeAdditional Notes
[Any additional context, screenshots, or information that reviewers should be aware of]