From 76c77f5f17805c3cdb2bc50284248bdae8110bf5 Mon Sep 17 00:00:00 2001 From: Pratyush Meduri Date: Fri, 19 Dec 2025 17:56:28 +0530 Subject: [PATCH 1/3] audioreach-driver: q6apm_audio_pkt: Correct device name assignment Remove dev_name and ch_name from q6apm_audio_pkt as they are constant across all driver instances and do not need to be stored per-instance. Replace their usage with the static AUDPKT_DRIVER_NAME, saving memory and simplifying logic. Signed-off-by: Pratyush Meduri --- audioreach-driver/q6apm_audio_pkt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/audioreach-driver/q6apm_audio_pkt.c b/audioreach-driver/q6apm_audio_pkt.c index 2a6db54..680a6f3 100644 --- a/audioreach-driver/q6apm_audio_pkt.c +++ b/audioreach-driver/q6apm_audio_pkt.c @@ -54,7 +54,6 @@ do { \ #define MODULE_NAME "audio-pkt" #define MINOR_NUMBER_COUNT 1 #define AUDPKT_DRIVER_NAME "aud_pasthru_adsp" -#define CHANNEL_NAME "to_apps" #define APM_AUDIO_DRV_NAME "q6apm-audio-pkt" struct q6apm_audio_pkt { @@ -74,8 +73,6 @@ struct q6apm_audio_pkt { spinlock_t queue_lock; struct sk_buff_head queue; wait_queue_head_t readq; - char dev_name[20]; - char ch_name[20]; dev_t audio_pkt_major; struct class *audio_pkt_class; @@ -552,10 +549,7 @@ static int q6apm_audio_pkt_probe(gpr_device_t *adev) goto err_device; } - strscpy(apm->dev_name, CHANNEL_NAME, 20); - strscpy(apm->ch_name, CHANNEL_NAME, 20); - dev_set_name(apm->dev, apm->dev_name); - + dev_set_name(apm->dev, AUDPKT_DRIVER_NAME); dev_set_drvdata(dev, apm); From 34c365fb5f197a1d34200bae70864601441649b2 Mon Sep 17 00:00:00 2001 From: Pratyush Meduri Date: Sun, 21 Dec 2025 17:50:01 +0530 Subject: [PATCH 2/3] audio-pkt: Fix compilation error by removing unused variables Previous PR [1] left unused variables in error logs: - audpkt_dev->ch_name - apm->dev_name This patch removes these references to resolve build failures. [1] https://github.com/AudioReach/audioreach-kernel/pull/30/commits Signed-off-by: Pratyush Meduri --- audioreach-driver/q6apm_audio_pkt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/audioreach-driver/q6apm_audio_pkt.c b/audioreach-driver/q6apm_audio_pkt.c index 680a6f3..f2ae9d6 100644 --- a/audioreach-driver/q6apm_audio_pkt.c +++ b/audioreach-driver/q6apm_audio_pkt.c @@ -261,8 +261,6 @@ static int audio_pkt_open(struct inode *inode, struct file *file) struct q6apm_audio_pkt *audpkt_dev = cdev_to_audpkt_dev(inode->i_cdev); struct device *dev = audpkt_dev->dev; - AUDIO_PKT_ERR("for %s\n", audpkt_dev->ch_name); - get_device(dev); file->private_data = audpkt_dev; @@ -572,8 +570,7 @@ static int q6apm_audio_pkt_probe(gpr_device_t *adev) ret = cdev_add(&apm->cdev, apm->audio_pkt_major, MINOR_NUMBER_COUNT); if (ret) { - AUDIO_PKT_ERR("cdev_add failed for %s ret:%d\n", - apm->dev_name, ret); + AUDIO_PKT_ERR("cdev_add failed with ret:%d\n",ret); goto free_dev; } From 2dc8954bc00ec918908e246774851cddf999496d Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Tue, 23 Dec 2025 10:19:25 +0530 Subject: [PATCH 3/3] Update audio-pkt.c sample run This is for testing kernel change Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index 14dfd83..3f26d03 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -60,6 +60,8 @@ do { \ * @audio_pkt_major: Major number of audio pkt driver * @audio_pkt_class: audio pkt class pointer */ + +# test run struct audio_pkt_device { gpr_device_t *adev; struct device *dev;