Dedupe Rust sidebars for tmux grouped sessions#37
Open
colelawrence wants to merge 1 commit into
Open
Conversation
- Tmux grouped sessions expose the same physical windows and panes under multiple session names, which made Rust sidebar toggles spawn duplicate sidebars into one window. - Deduplicate sidebar window and pane discovery by physical tmux ids while preserving the active linked-session identity for spawn context.
There was a problem hiding this comment.
inspect review
Triage: 13 entities analyzed | 0 critical, 0 high, 8 medium, 5 low
Verdict: standard_review
Findings (1)
- [low] Test/implementation mismatch in tmux_provider window dedupe: list_active_windows only replaces an existing entry when current.active==false && next.active==true, but the new test tmux_provider_deduplicates_grouped_session_windows_by_window_id expects the second @1 entry (alpha-2) to win even though the first @1 entry is already active. Diff evidence: implementation in packages/runtime-rs/src/tmux_provider.rs uses
if !current.active && next.active { *current = next; }and the test data marks alpha-2 active (...alpha-2...1...) while alpha is also active per the test fixture; test asserts session_name == "alpha-2". This will fail if the first entry is active.
Reviewed by inspect | Entity-level triage found 0 high-risk changes
Member
|
Thanks for the PR @colelawrence, will review it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification