fix: address CodeRabbit findings (round 1)

- Widen compareByContestIdAndTaskId signature to accept any object with
  contest_id/task_table_index, removing double cast in +page.svelte
- Replace find() loop with Map in buildDonutSegments (O(n+m))
- Extract segLabel {@const} in VoteDonutChart to remove duplicate ternary
- Add aria-label to FlaskConical in VotableGrade
- Add aria-label to external link icon in votes list page
- Add qGrades/dGrades tests to grade_options.test.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: river0525

src/features/votes/components/VotableGrade.svelte

@@ -161,7 +161,10 @@
   </button>
 
   {#if isProvisional}
-    <FlaskConical class="w-3.5 h-3.5 shrink-0 text-gray-400 dark:text-gray-500" />
+    <FlaskConical
+      class="w-3.5 h-3.5 shrink-0 text-gray-400 dark:text-gray-500"
+      aria-label="暫定グレード"
+    />
   {/if}
 </div>
 

src/features/votes/components/VoteDonutChart.svelte

@@ -84,6 +84,7 @@
     {#each segments as seg (seg.grade)}
       {@const lx = CX + RING_MID_RADIUS * Math.cos(seg.midAngle)}
       {@const ly = CY + RING_MID_RADIUS * Math.sin(seg.midAngle)}
+      {@const segLabel = seg.grade === votedGrade ? `✅ ${seg.label}` : seg.label}
       {#if seg.pct >= 10}
         <text
           x={lx}
@@ -95,7 +96,7 @@
           stroke-width="2.5"
           paint-order="stroke"
           font-size="11"
-          font-weight="bold">{seg.grade === votedGrade ? `✅ ${seg.label}` : seg.label}</text
+          font-weight="bold">{segLabel}</text
         >
         <text
           x={lx}
@@ -119,7 +120,7 @@
           stroke-width="2.5"
           paint-order="stroke"
           font-size="11"
-          font-weight="bold">{seg.grade === votedGrade ? `✅ ${seg.label}` : seg.label}</text
+          font-weight="bold">{segLabel}</text
         >
       {/if}
     {/each}

src/features/votes/utils/donut_chart.ts

@@ -40,11 +40,12 @@ export function buildDonutSegments(
     return [];
   }
 
+  const countMap = new Map(counters.map((c) => [c.grade, c.count]));
   let cumulative = 0;
   const segments: DonutSegment[] = [];
 
   for (const grade of grades) {
-    const count = counters.find((c) => c.grade === grade)?.count ?? 0;
+    const count = countMap.get(grade) ?? 0;
     if (count === 0) {
       continue;
     }

src/features/votes/utils/grade_options.test.ts

@@ -2,7 +2,7 @@ import { describe, expect, it } from 'vitest';
 
 import { TaskGrade, taskGradeValues } from '$lib/types/task';
 
-import { nonPendingGrades } from './grade_options';
+import { nonPendingGrades, qGrades, dGrades } from './grade_options';
 
 describe('nonPendingGrades', () => {
   it('does not include PENDING', () => {
@@ -19,3 +19,41 @@ describe('nonPendingGrades', () => {
     expect(nonPendingGrades[nonPendingGrades.length - 1]).toBe(TaskGrade.D6);
   });
 });
+
+describe('qGrades', () => {
+  it('contains only Q-tier grades', () => {
+    expect(qGrades.every((g) => g.startsWith('Q'))).toBe(true);
+  });
+
+  it('contains no D-tier grades', () => {
+    expect(qGrades.some((g) => g.startsWith('D'))).toBe(false);
+  });
+
+  it('equals nonPendingGrades filtered to Q prefix', () => {
+    expect(qGrades).toEqual(nonPendingGrades.filter((g) => g.startsWith('Q')));
+  });
+
+  it('starts with Q11 and ends with Q1', () => {
+    expect(qGrades[0]).toBe(TaskGrade.Q11);
+    expect(qGrades[qGrades.length - 1]).toBe(TaskGrade.Q1);
+  });
+});
+
+describe('dGrades', () => {
+  it('contains only D-tier grades', () => {
+    expect(dGrades.every((g) => g.startsWith('D'))).toBe(true);
+  });
+
+  it('contains no Q-tier grades', () => {
+    expect(dGrades.some((g) => g.startsWith('Q'))).toBe(false);
+  });
+
+  it('equals nonPendingGrades filtered to D prefix', () => {
+    expect(dGrades).toEqual(nonPendingGrades.filter((g) => g.startsWith('D')));
+  });
+
+  it('starts with D1 and ends with D6', () => {
+    expect(dGrades[0]).toBe(TaskGrade.D1);
+    expect(dGrades[dGrades.length - 1]).toBe(TaskGrade.D6);
+  });
+});

src/lib/utils/task.ts

@@ -72,7 +72,10 @@ export const areAllTasksAccepted = (
 
 // See:
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
-export function compareByContestIdAndTaskId(first: TaskResult, second: TaskResult): number {
+export function compareByContestIdAndTaskId(
+  first: { contest_id: string; task_table_index: string },
+  second: { contest_id: string; task_table_index: string },
+): number {
   const firstContestPriority = getContestPriority(first.contest_id);
   const secondContestPriority = getContestPriority(second.contest_id);
 

src/routes/votes/+page.svelte

@@ -19,7 +19,6 @@
   import { getTaskUrl } from '$lib/utils/task';
   import { getContestNameLabel } from '$lib/utils/contest';
   import { compareByContestIdAndTaskId } from '$lib/utils/task';
-  import type { TaskResult } from '$lib/types/task';
 
   const MAX_SEARCH_RESULTS = 20;
 
@@ -37,9 +36,7 @@
               (t.task_id ?? '').toLowerCase().includes(search.toLowerCase()) ||
               (t.contest_id ?? '').toLowerCase().includes(search.toLowerCase()),
           )
-          .sort((a, b) =>
-            compareByContestIdAndTaskId(a as unknown as TaskResult, b as unknown as TaskResult),
-          )
+          .sort((a, b) => compareByContestIdAndTaskId(a, b))
           .slice(0, MAX_SEARCH_RESULTS),
   );
 </script>
@@ -107,9 +104,10 @@
                     href={getTaskUrl(task.contest_id, task.task_id)}
                     target="_blank"
                     rel="noreferrer external"
+                    aria-label={`${task.title} を別タブで開く`}
                     class="text-gray-400 hover:text-gray-600 dark:hover:text-gray-300 shrink-0"
                   >
-                    <ExternalLink class="w-3.5 h-3.5" />
+                    <ExternalLink class="w-3.5 h-3.5" aria-hidden="true" />
                   </a>
                 </div>
               </TableBodyCell>