Attempt to perform string conversion on a secret string value

[b-morgan]

The following error occurs when Lorewalking with Cho

61x attempt to perform string conversion on a secret string value (tainted by 'MovementSpeed')
[MovementSpeed/Main.lua]:502: in function <MovementSpeed/Main.lua:490>


Locals:
(for index) = 2
(for limit) = 4
(for step) = 1
i = 2
speed = <table> {
 travelSpeed = <table> {
 }
 playerSpeed = <table> {
 }
 targetSpeed = <table> {
 }
}
map = <table> {
 id = 18
 name = "Tirisfal Glades"
 size = <table> {
 }
}
lineAdded = false
tooltip = GameTooltip {
 ItemTooltip = Frame {
 }
 BottomOverlay = Texture {
 }
 NineSlice = Frame {
 }
 suppressAutomaticCompareItem = false
 textLeft1Font = "GameTooltipHeaderText"
 textRight2Font = "GameTooltipText"
 TopOverlay = Texture {
 }
 TextLeft1 = GameTooltipTextLeft1 {
 }
 processingInfo = <table> {
 }
 infoList = <table> {
 }
 alink = "|cffffff00|Hquest:84371:3011|h[Lorewalking: The Blade and the High Priest]|h|r"
 supportsItemComparison = true
 supportsDataRefresh = true
 shouldRefreshData = false
 waitingForData = false
 __tooltipUpdated = false
 shoppingTooltips = <table> {
 }
 updateTooltipTimer = 0.167000
 StatusBar = GameTooltipStatusBar {
 }
 TextRight1 = GameTooltipTextRight1 {
 }
 textLeft2Font = "GameTooltipText"
 layoutType = "TooltipDefaultLayout"
 textRight1Font = "GameTooltipHeaderText"
 TextRight2 = GameTooltipTextRight2 {
 }
 TextLeft2 = GameTooltipTextLeft2 {
 }
}
line = GameTooltipTextLeft2 {
}
wt = <table> {
 textures = <table> {
 }
 settingsTable = <table> {
 }
 classic = false
 colors = <table> {
 }
 strings = <table> {
 }
}
ns = <table> {
 textures = <table> {
 }
 WidgetToolboxVersion = "2.1"
 root = "MovementSpeed/"
 tooltip = MovementSpeedGameTooltip {
 }
 chat = <table> {
 }
 fonts = <table> {
 }
 WidgetToolbox = <table> {
 }
 title = "Movement Speed"
 profileDefault = <table> {
 }
 name = "MovementSpeed"
 colors = <table> {
 }
 changelog = <table> {
 }
 strings = <table> {
 }
}

[Neila142]

Had the same issues when doing Delves:

5139x attempt to perform string conversion on a secret string value (tainted by 'MovementSpeed')
[MovementSpeed/Main.lua]:502: in function <MovementSpeed/Main.lua:490>


Locals:
(for index) = 2
(for limit) = 8
(for step) = 1
i = 2
speed = <table> {
 travelSpeed = <table> {
 }
 playerSpeed = <table> {
 }
 targetSpeed = <table> {
 }
}
map = <table> {
 id = 2535
 name = "Atal’Aman"
 size = <table> {
 }
}
lineAdded = false
tooltip = GameTooltip {
 ItemTooltip = Frame {
 }
 AllTheThingsOnTooltipClearedHook = true
 BottomOverlay = Texture {
 }
 NineSlice = Frame {
 }
 suppressAutomaticCompareItem = false
 textLeft1Font = "GameTooltipHeaderText"
 hasMoney = 1
 TopOverlay = Texture {
 }
 TextLeft1 = GameTooltipTextLeft1 {
 }
 AllTheThingsProcessing = <no value>
 processingInfo = <table> {
 }
 infoList = <table> {
 }
 numMoneyFrames = 1
 supportsDataRefresh = true
 CIMI_tooltipWritten = false
 waitingForData = false
 StatusBar = GameTooltipStatusBar {
 }
 shoppingTooltips = <table> {
 }
 updateTooltipTimer = 0.099000
 TextRight1 = GameTooltipTextRight1 {
 }
 supportsItemComparison = true
 textLeft2Font = "GameTooltipText"
 widgetContainer = Frame {
 }
 layoutType = "TooltipDefaultLayout"
 textRight1Font = "GameTooltipHeaderText"
 __hasCounters = false
 TextRight2 = GameTooltipTextRight2 {
 }
 TextLeft2 = GameTooltipTextLeft2 {
 }
 textRight2Font = "GameTooltipText"
}
line = GameTooltipTextLeft2 {
}
wt = <table> {
 textures = <table> {
 }
 settingsTable = <table> {
 }
 classic = false
 colors = <table> {
 }
 strings = <table> {
 }
}
ns = <table> {
 textures = <table> {
 }
 WidgetToolboxVersion = "2.1"
 root = "MovementSpeed/"
 tooltip = MovementSpeedGameTooltip {
 }
 chat = <table> {
 }
 fonts = <table> {
 }
 WidgetToolbox = <table> {
 }
 title = "Movement Speed"
 profileDefault = <table> {
 }
 name = "MovementSpeed"
 colors = <table> {
 }
 changelog = <table> {
 }
 strings = <table> {
 }
}

[Arxareon]

Thank y'all for the reports!

I have also noticed issues that cropped up since Blizzard's addoncalypse like the finale fight of Val'sharah or other prive shards players are put into during questing or delving. They are not reported as actual instances by the game but they do have the same addon restrictions in place. Movement Speed only checks for instances.

A quick fix anyone could do is fully disable the "Target Speed" inspect tooltip feature. The game does not allow addons to glean the speed info of enemies in instances, or, as it turns out in any private phase. I'll have to do some further investigation to confirm my suspicions and I'll have to think up a solution. I'll get to it as soon as I can. ❤️‍🩹

[mario-64]

Just confirming the issue as others have reported. Multiple string errors when doing a delve.

[NeoPavio]

I was having the issue with the string errors and came to a quick fix.
IsInInstance() does return a boolean and the InstanceType.
As delves are not an instance it returns false and the InstanceType "scenario".
And as the mouseover functionality is already disabled by the IsInInstance() check, I just added a check for "scenario".
I don't know if you already implemented this in the next update, so I'll just put my solution here:

old:
if IsInInstance() and not UnitIsFriend("player", "mouseover") then return end

my solution:
playerInstance, playerScenario = IsInInstance()
if (playerInstance or playerScenario == "scenario") and not UnitIsFriend("player", "mouseover") then return end

[Arxareon]

Thanks for the heads-up and the suggestion @NeoPavio! I encountered this during questing as well, not just in delves, I'm not sure if all of the instances it can happen would be considered a "scenario" but I'd guess probably yes. How I soled it was adding a check later down the line for the actual value if it is a secret or not to catch every single case regardless of why it becomes a secret. The downside is that this check is further in the chain and won't exit as soon as the main guard so I will probably refine it in a future update. Or, I might test out your solution later.