chore: cleaning up dead code and old todos

Author: SuperFola

.github/workflows/ci.yml

@@ -176,7 +176,7 @@ jobs:
           compiler_version: 16
           sanitizers: On
           coverage: On
-          with_deps: false
+          with_deps: true
 
       - name: Run tests
         run: |

include/Ark/Compiler/BytecodeReader.hpp

@@ -2,10 +2,10 @@
  * @file BytecodeReader.hpp
  * @author Alexandre Plateau (lexplt.dev@gmail.com)
  * @brief A bytecode disassembler for ArkScript
- * @version 0.5
+ * @version 1.0
  * @date 2020-10-27
  *
- * @copyright Copyright (c) 2020-2024
+ * @copyright Copyright (c) 2020-2025
  *
  */
 
@@ -96,13 +96,6 @@ namespace Ark
          */
         [[nodiscard]] bool checkMagic() const;
 
-        /**
-         * @brief Return the bytecode object constructed
-         *
-         * @return const bytecode_t&
-         */
-        [[nodiscard]] const bytecode_t& bytecode() noexcept;
-
         /**
          *
          * @return Version compiler version used to create the given bytecode file

include/Ark/Files.hpp

@@ -77,7 +77,6 @@ namespace Ark::Utils
         ifs.close();
 
         auto bytecode = std::vector<uint8_t>(static_cast<std::size_t>(pos));
-        // TODO would it be faster to memcpy?
         for (std::size_t i = 0; i < static_cast<std::size_t>(pos); ++i)
             bytecode[i] = static_cast<uint8_t>(temp[i]);
         return bytecode;

src/arkreactor/Builtins/List.cpp

@@ -51,13 +51,8 @@ namespace Ark::internal::Builtins::List
                 { { types::Contract { { types::Typedef("list", ValueType::List), types::Typedef("value", ValueType::Any) } } } },
                 n);
 
-        std::vector<Value>& l = n[0].list();
-        for (auto it = l.begin(), it_end = l.end(); it != it_end; ++it)
-        {
-            if (*it == n[1])  // FIXME cast
-                return Value(static_cast<int>(std::distance<Value::Iterator>(l.begin(), it)));
-        }
-
+        if (const auto it = std::ranges::find(n[0].list(), n[1]); it != n[0].list().end())
+            return Value(static_cast<int>(std::distance<Value::Iterator>(n[0].list().begin(), it)));
         return Value(-1);
     }
 

src/arkreactor/Builtins/Mathematics.cpp

@@ -43,12 +43,12 @@ namespace Ark::internal::Builtins::Mathematics
     {
         if (!types::check(n, ValueType::Number))
             types::generateError(
-                "math:log",
+                "math:ln",
                 { { types::Contract { { types::Typedef("value", ValueType::Number) } } } },
                 n);
 
         if (n[0].number() <= 0.0)
-            throw std::runtime_error(fmt::format("math:log: value {} must be greater than 0", n[0].number()));
+            throw std::runtime_error(fmt::format("math:ln: value {} must be greater than 0", n[0].number()));
 
         return Value(std::log(n[0].number()));
     }
@@ -128,7 +128,7 @@ namespace Ark::internal::Builtins::Mathematics
     {
         if (!types::check(n, ValueType::Any))
             types::generateError(
-                "math:exp",
+                "math:NaN?",
                 { { types::Contract { { types::Typedef("value", ValueType::Any) } } } },
                 n);
 

src/arkreactor/Compiler/AST/Parser.cpp

@@ -353,7 +353,7 @@ namespace Ark::internal
         Node symbols(NodeType::List);
         setNodePosAndFilename(symbols);
         // then parse the symbols to import, if any
-        if (space())  // FIXME: potential regression introduced here
+        if (space())
         {
             comment.clear();
             newlineOrComment(&comment);

src/arkreactor/Compiler/BytecodeReader.cpp

@@ -47,11 +47,6 @@ namespace Ark
             m_bytecode[3] == bytecode::Magic[3];
     }
 
-    const bytecode_t& BytecodeReader::bytecode() noexcept
-    {
-        return m_bytecode;
-    }
-
     Version BytecodeReader::version() const
     {
         if (!checkMagic() || m_bytecode.size() < bytecode::Magic.size() + bytecode::Version.size())

src/arkreactor/Compiler/Macros/Processor.cpp

@@ -79,7 +79,7 @@ namespace Ark::internal
     {
         if (node.nodeType() == NodeType::List && node.constList().size() == 3 && node.constList()[0].nodeType() == NodeType::Keyword)
         {
-            Keyword kw = node.constList()[0].keyword();
+            const Keyword kw = node.constList()[0].keyword();
             // checking for function definition, which can occur only inside an assignment node
             if (kw != Keyword::Let && kw != Keyword::Mut && kw != Keyword::Set)
                 return;
@@ -99,7 +99,7 @@ namespace Ark::internal
         }
     }
 
-    void MacroProcessor::processNode(Node& node, unsigned depth, bool is_processing_namespace)
+    void MacroProcessor::processNode(Node& node, unsigned depth, const bool is_processing_namespace)
     {
         if (depth >= MaxMacroProcessingDepth)
             throwMacroProcessingError(
@@ -666,7 +666,7 @@ namespace Ark::internal
             node.constList()[0].keyword() == Keyword::Begin;
     }
 
-    void MacroProcessor::removeBegin(Node& node, std::size_t i)
+    void MacroProcessor::removeBegin(Node& node, const std::size_t i)
     {
         if (node.isListLike() && node.list()[i].nodeType() == NodeType::List && !node.list()[i].list().empty())
         {

src/arkreactor/Exceptions.cpp

@@ -194,7 +194,6 @@ namespace Ark::Diagnostics
         if (e.filename != ARK_NO_NAME_FILE)
             file_content = Utils::readFile(e.filename);
 
-        // TODO enhance the error messages
         helper(
             os,
             e.what(),

src/arkreactor/VM/VM.cpp

@@ -1637,21 +1637,13 @@ namespace Ark
                     fmt::styled(m_state.m_symbols[old_scope.atPos(i).first], fmt::fg(fmt::color::cyan)),
                     old_scope.atPos(i).second.toString(*this));
             }
-
-            while (context.fc != 1)
-            {
-                Value* tmp = pop(context);
-                if (tmp->valueType() == ValueType::InstPtr)
-                    --context.fc;
-                *tmp = m_no_value;
-            }
-            // pop the PP as well
-            pop(context);
         }
 
-        std::cerr << "At IP: " << (saved_ip / 4)  // dividing by 4 because the instructions are actually on 4 bytes
-                  << ", PP: " << saved_pp
-                  << ", SP: " << saved_sp
-                  << "\n";
+        fmt::println(
+            "At IP: {}, PP: {}, SP: {}",
+            // dividing by 4 because the instructions are actually on 4 bytes
+            fmt::styled(saved_ip / 4, fmt::fg(fmt::color::cyan)),
+            fmt::styled(saved_pp, fmt::fg(fmt::color::green)),
+            fmt::styled(saved_sp, fmt::fg(fmt::color::yellow)));
     }
 }