fix: 'and' and 'or' now check that they are given valid nodes, producing outputs

Author: SuperFola

src/arkreactor/Compiler/Lowerer/ASTLowerer.cpp

@@ -620,7 +620,14 @@ namespace Ark::internal
                         node.string(),
                         x.constList().size() - 1),
                     x);
+            const auto name = node.string();  // and / or
 
+            if (!nodeProducesOutput(x.list()[1]))
+                buildAndThrowError(
+                    fmt::format(
+                        "Can not use `{}' inside a `{}' expression, as it doesn't return a value",
+                        x.list()[1].repr(), name),
+                    x.list()[1]);
             compileExpression(x.list()[1], p, false, false);
 
             const auto label_shortcircuit = IR::Entity::Label(m_current_label++);
@@ -629,6 +636,12 @@ namespace Ark::internal
 
             for (std::size_t i = 2, end = x.constList().size(); i < end; ++i)
             {
+                if (!nodeProducesOutput(x.list()[i]))
+                    buildAndThrowError(
+                        fmt::format(
+                            "Can not use `{}' inside a `{}' expression, as it doesn't return a value",
+                            x.list()[i].repr(), name),
+                        x.list()[i]);
                 compileExpression(x.list()[i], p, false, false);
                 if (i + 1 != end)
                     page(p).emplace_back(shortcircuit_entity);

tests/unittests/resources/DiagnosticsSuite/compileTime/or_1_mut.ark

@@ -0,0 +1 @@
+(print (or 1 (mut x 3)))

tests/unittests/resources/DiagnosticsSuite/compileTime/or_1_mut.expected

@@ -0,0 +1,5 @@
+In file tests/unittests/resources/DiagnosticsSuite/compileTime/or_1_mut.ark:1
+    1 | (print (or 1 (mut x 3)))
+      |              ^~~~~~~~
+    2 |
+        Can not use `(mut x 3)' inside a `or' expression, as it doesn't return a value

tests/unittests/resources/DiagnosticsSuite/compileTime/or_let_1.ark

@@ -0,0 +1 @@
+(print (or (let x 1) 1))

tests/unittests/resources/DiagnosticsSuite/compileTime/or_let_1.expected

@@ -0,0 +1,5 @@
+In file tests/unittests/resources/DiagnosticsSuite/compileTime/or_let_1.ark:1
+    1 | (print (or (let x 1) 1))
+      |            ^~~~~~~~
+    2 |
+        Can not use `(let x 1)' inside a `or' expression, as it doesn't return a value