fix: when compiling code for the debugger, set is_result_unused to true

Author: SuperFola

src/arkreactor/Compiler/Lowerer/ASTLowerer.cpp

@@ -37,9 +37,11 @@ namespace Ark::internal
         // gather symbols, values, and start to create code segments
         compileExpression(
             ast,
-            /* current_page */ global,
-            /* is_result_unused */ false,
-            /* is_terminal */ false);
+            /* current_page= */ global,
+            // the offset is non-zero when coming from the debugger, and setting is_result_unused to
+            // true will avoid adding a LOAD_FAST/LOAD_FAST_FROM_INDEX after a let/mut/set
+            /* is_result_unused= */ m_start_page_at_offset != 0,
+            /* is_terminal= */ false);
         m_logger.traceEnd();
     }
 

tests/unittests/resources/DebuggerSuite/basic.expected

@@ -7,7 +7,6 @@ In file tests/unittests/resources/DebuggerSuite/basic.ark:3
     5 |
 
 dbg[pp:0,ip:3]:000> (let c (+ a b))
-11
 dbg[pp:0,ip:3]:001> (prn c)
 11
 dbg[pp:0,ip:3]:002> c
@@ -25,7 +24,6 @@ In file tests/unittests/resources/DebuggerSuite/basic.ark:7
 
 dbg[pp:1,ip:5]:000> (prn x y z)
 567
-nil
 dbg[pp:1,ip:5]:001> help
 Available commands:
   help -- display this message

tests/unittests/resources/DebuggerSuite/debugger_quit.expected

@@ -7,7 +7,6 @@ In file tests/unittests/resources/DebuggerSuite/debugger_quit.ark:3
     5 |
 
 dbg[pp:0,ip:3]:000> (let c (+ a b))
-11
 dbg[pp:0,ip:3]:001> (prn c)
 11
 dbg[pp:0,ip:3]:002> q

tests/unittests/resources/DebuggerSuite/loop.expected

@@ -15,7 +15,6 @@ In file tests/unittests/resources/DebuggerSuite/loop.ark:3
 
 dbg[pp:0,ip:8]:000> (prn i)
 6
-nil
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=6
@@ -30,7 +29,6 @@ In file tests/unittests/resources/DebuggerSuite/loop.ark:3
 
 dbg[pp:0,ip:8]:000> (prn i)
 7
-nil
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=7
@@ -45,7 +43,6 @@ In file tests/unittests/resources/DebuggerSuite/loop.ark:3
 
 dbg[pp:0,ip:8]:000> (prn i)
 8
-nil
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=8
@@ -60,7 +57,6 @@ In file tests/unittests/resources/DebuggerSuite/loop.ark:3
 
 dbg[pp:0,ip:8]:000> (prn i)
 9
-nil
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=9

tests/unittests/resources/DebuggerSuite/modify_program_state.expected

@@ -15,7 +15,6 @@ In file tests/unittests/resources/DebuggerSuite/modify_program_state.ark:3
 
 dbg[pp:0,ip:8]:000> (prn i)
 6
-nil
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=6
@@ -29,7 +28,6 @@ In file tests/unittests/resources/DebuggerSuite/modify_program_state.ark:3
     5 |   (set i (+ 1 i)) })
 
 dbg[pp:0,ip:8]:000> (set i 20)
-20
 dbg[pp:0,ip:8]:001> c
 dbg: continue
 ark: i=20

tests/unittests/resources/DebuggerSuite/on_error.expected

@@ -1,8 +1,6 @@
 dbg[pp:0,ip:3]:000> (prn a)
 5
-nil
 dbg[pp:0,ip:3]:001> (prn (type a))
 Number
-nil
 dbg[pp:0,ip:3]:002> c
 dbg: continue