feat(tests): adding parser tests to improve coverage

Author: SuperFola

include/Ark/Compiler/AST/BaseParser.hpp

@@ -30,9 +30,8 @@ namespace Ark::internal
         std::string m_str;
         std::vector<std::pair<std::string::iterator, std::size_t>> m_it_to_row;  ///< A crude map of \n position to line number to speed up line number computing
         std::string::iterator m_it, m_next_it;
-        utf8_char_t m_sym;                ///< The current utf8 character we're on
-        FilePosition m_filepos;           ///< The position of the cursor in the file
-        FilePosition m_previous_filepos;  ///< The previous position of the cursor in the file
+        utf8_char_t m_sym;       ///< The current utf8 character we're on
+        FilePosition m_filepos;  ///< The position of the cursor in the file
 
         /**
          * @brief Register the position of a new line, with an iterator pointing to the new line and the row number
@@ -53,7 +52,6 @@ namespace Ark::internal
         void initParser(const std::string& filename, const std::string& code);
 
         [[nodiscard]] FilePosition getCursor() const;
-        [[nodiscard]] FilePosition getPreviousCursor() const;
 
         [[nodiscard]] CodeErrorContext generateErrorContextAtCurrentPosition() const;
 

src/arkreactor/Compiler/AST/BaseParser.cpp

@@ -51,8 +51,6 @@ namespace Ark::internal
         m_next_it = it;
         m_sym = sym;
 
-        m_previous_filepos = m_filepos;
-
         if (*m_it == '\n')
         {
             ++m_filepos.row;
@@ -109,21 +107,13 @@ namespace Ark::internal
             m_filepos.col = it_pos - nearest_newline_index;
         else
             m_filepos.col = it_pos + 1;
-        // We can say that the previous position is the current one, as there isn't anything usable right now
-        // Which means we will have to use accept()/next(), which will move filepos and previous_filepos correctly
-        m_previous_filepos = m_filepos;
     }
 
     FilePosition BaseParser::getCursor() const
     {
         return m_filepos;
     }
 
-    FilePosition BaseParser::getPreviousCursor() const
-    {
-        return m_previous_filepos;
-    }
-
     CodeErrorContext BaseParser::generateErrorContextAtCurrentPosition() const
     {
         const auto [row, col] = getCursor();

src/arkreactor/Compiler/AST/Parser.cpp

@@ -473,7 +473,7 @@ namespace Ark::internal
                 has_captures = true;
                 std::string capture;
                 if (!name(&capture))
-                    break;
+                    error("No symbol provided to capture", pos);
 
                 args->push_back(positioned(Node(NodeType::Capture, capture), pos));
             }
@@ -647,12 +647,7 @@ namespace Ark::internal
 
         comment = newlineOrComment();
         if (!comment.empty())
-        {
-            if (args->list().empty())
-                args->attachCommentAfter(comment);
-            else
-                args->list().back().attachCommentAfter(comment);
-        }
+            args->attachCommentAfter(comment);
 
         return positioned(args, filepos);
     }
@@ -858,7 +853,7 @@ namespace Ark::internal
                                 res += "u" + seq;
                         }
                         else
-                            error("Invalid escape sequence", pos);
+                            error("Invalid escape sequence, expected 4 hex digits: \\uabcd", pos);
                     }
                     else if (accept(IsChar('U')))
                     {
@@ -880,7 +875,7 @@ namespace Ark::internal
                                 res += "U" + seq;
                         }
                         else
-                            error("Invalid escape sequence", pos);
+                            error("Invalid escape sequence, expected 8 hex digits: \\UABCDEF78", pos);
                     }
                     else
                     {

tests/unittests/resources/DiagnosticsSuite/compileTime/empty_capture.ark

@@ -0,0 +1 @@
+(let foo (fun (a b &) ()))

tests/unittests/resources/DiagnosticsSuite/compileTime/empty_capture.expected

@@ -0,0 +1,4 @@
+    1 | (let foo (fun (a b &) ()))
+      |                    ^
+    2 |
+        No symbol provided to capture

tests/unittests/resources/FormatterSuite/comment_after_macro_args.ark

@@ -0,0 +1,5 @@
+(macro bar (
+a
+b
+) # c
+())

tests/unittests/resources/FormatterSuite/comment_after_macro_args.expected

@@ -0,0 +1,2 @@
+(macro bar (a b) # c
+  ())

tests/unittests/resources/ParserSuite/failure/incomplete_field.ark

@@ -0,0 +1 @@
+(print a.)

tests/unittests/resources/ParserSuite/failure/incomplete_field.expected

@@ -0,0 +1,5 @@
+In file tests/unittests/resources/ParserSuite/failure/incomplete_field.ark:1
+    1 | (print a.)
+      |          ^
+    2 |
+        Expected a field name: <symbol>.<field>

tests/unittests/resources/ParserSuite/failure/incomplete_fun_in_macro.ark

@@ -0,0 +1,2 @@
+(macro bar {
+  (let foo (fun (a b))) })