feat(tests): adding more failing tests for macros

Author: SuperFola

src/arkreactor/Compiler/Macros/Processor.cpp

@@ -210,28 +210,30 @@ namespace Ark::internal
 
     void MacroProcessor::checkMacroArgCountEq(const Node& node, std::size_t expected, const std::string& name, const std::string& kind)
     {
-        const std::size_t argcount = node.constList().size();
+        const std::size_t argcount = node.constList().size() - 1;
         if (argcount != expected + 1)
             throwMacroProcessingError(
                 fmt::format(
-                    "Interpreting a `{}'{} with {} arguments, expected {}.",
+                    "Interpreting a `{}'{} with {} argument{}, expected {}.",
                     name,
                     kind.empty() ? kind : " " + kind,
                     argcount,
+                    argcount > 1 ? "s" : "",
                     expected),
                 node);
     }
 
     void MacroProcessor::checkMacroArgCountGe(const Node& node, std::size_t expected, const std::string& name, const std::string& kind)
     {
-        const std::size_t argcount = node.constList().size();
+        const std::size_t argcount = node.constList().size() - 1;
         if (argcount < expected + 1)
             throwMacroProcessingError(
                 fmt::format(
-                    "Interpreting a `{}'{} with {} arguments, expected at least {}.",
+                    "Interpreting a `{}'{} with {} argument{}, expected at least {}.",
                     name,
                     kind.empty() ? kind : " " + kind,
                     argcount,
+                    argcount > 1 ? "s" : "",
                     expected),
                 node);
     }

tests/unittests/resources/DiagnosticsSuite/compileTime/builtin_conflict_resolution.ark

@@ -0,0 +1,3 @@
+(import package.builtin__list)
+
+(print (reverse))

tests/unittests/resources/DiagnosticsSuite/compileTime/builtin_conflict_resolution.expected

@@ -0,0 +1,6 @@
+    1 | (import package.builtin__list)
+    2 |
+    3 | (print (reverse))
+      |         ^~~~~~~
+    4 |
+        Symbol `reverse' was resolved to `builtin__list:reverse', which is also a builtin name. Either the symbol or the package it's in needs to be renamed to avoid conflicting with the builtin.

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_argcount_type_error.ark

@@ -0,0 +1 @@
+($argcount 1)

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_argcount_type_error.expected

@@ -0,0 +1,6 @@
+    1 | ($argcount 1)
+      | │          └─ error
+      | │
+      | └─ macro expansion started here
+    2 |
+        When trying to apply `$argcount', got a Number instead of a Symbol or Function

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_eq_not_enough_args.ark

@@ -0,0 +1 @@
+($if (= 1) ())

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_eq_not_enough_args.expected

@@ -0,0 +1,4 @@
+    1 | ($if (= 1) ())
+      |      ^~~~~
+    2 |
+        Interpreting a `=' condition with 1 argument, expected 2.

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_plus_not_enough_args.ark

@@ -0,0 +1 @@
+(macro a (+ 1))

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_plus_not_enough_args.expected

@@ -0,0 +1,4 @@
+    1 | (macro a (+ 1))
+      |          ^~~~~
+    2 |
+        Interpreting a `+' operator with 1 argument, expected at least 2.

tests/unittests/resources/DiagnosticsSuite/compileTime/macro_undef_arity_error.ark

@@ -0,0 +1 @@
+($undef a b)