nginx review

Author: Aingeru

Dockerfile

@@ -8,7 +8,7 @@ RUN apk update && apk upgrade && \
 ENV WEB_ROOT_PATH=/var/www/certbot
 
 # Copiar las configuraciones de nginx
-COPY ./nginx/conf /etc/nginx/conf.d
+COPY ./nginx /etc/nginx
 
 EXPOSE 80
 

nginx/conf/default.conf nginx/nginx.confnginx/conf/default.conf renamed to nginx/nginx.conf

@@ -1,16 +1,20 @@
 server {
     listen 80;
     listen [::]:80;
-    
-    server_name DOMAIN; # Setted by start.sh
+
+    server_name DOMAIN; # Set by start.sh
     server_tokens off;
 
+    # Disable access log to reduce disk I/O
+    access_log off;
+
     location / {
-        return 200 'gangnam style!';
         add_header Content-Type text/plain;
+        return 200 'gangnam style!';
     }
-
+    
     location /.well-known/acme-challenge/ {
         root /var/www/certbot;
+        try_files $uri =404;
     }
 }

start.sh

@@ -21,12 +21,16 @@ fi
 if [ ! -d "${WEB_ROOT_PATH}" ]; then
     mkdir -p "${WEB_ROOT_PATH}"
 fi
-sudo systemctl enable nginx
-sudo systemctl start nginx
+
+# Start Nginx service
+nginx
 
 # Launch challenge for domain, Nginx must be running with Certbot configuration to resolve
 certbot certonly -n --webroot --webroot-path ${WEB_ROOT_PATH} -d ${DOMAIN} --agree-tos --email ${EMAIL}
 
+# Stop Nginx service
+nginx -s stop
+
 if [ -f /etc/letsencrypt/live/${DOMAIN}/privkey.pem ] && [ -f /etc/letsencrypt/live/${DOMAIN}/cert.pem ]; then
 
     # Create PFX file from letsencrypt certificates resolved by Certbot, output on desired path that should be mapped with Docker volume