Merge pull request #522 from AppQuality/update-delete-attachment-logic

feat: update attachment deletion logic to ensure database records are…

Author: Kariamos

src/routes/campaigns/campaignId/finance/otherCosts/_delete/index.ts

@@ -63,16 +63,16 @@ export default class OtherCostsDeleteRoute extends CampaignRoute<{
       for (const attachment of attachments) {
         try {
           await deleteFromS3({ url: attachment.url });
+          await tryber.tables.WpAppqCampaignOtherCostsAttachment.do()
+            .where({ id: attachment.id })
+            .delete();
         } catch (e) {
           console.error(
             `Error deleting attachment from S3: ${attachment.url}`,
             e
           );
           throw new Error("Error deleting attachment from S3");
         }
-        await tryber.tables.WpAppqCampaignOtherCostsAttachment.do()
-          .where({ id: attachment.id })
-          .delete();
       }
     }