From 556d2b3b3e3da8e9b5c6aa0cdf0f39af921f185e Mon Sep 17 00:00:00 2001 From: Hannes Achleitner Date: Wed, 24 Dec 2025 11:04:07 +0100 Subject: [PATCH 1/2] Cosmetic --- .../mikephil/charting/listener/BarLineChartTouchListener.kt | 6 ++---- .../com/github/mikephil/charting/listener/OnDrawListener.kt | 2 +- .../github/mikephil/charting/renderer/BarChartRenderer.kt | 3 +-- .../github/mikephil/charting/renderer/LineChartRenderer.kt | 3 +-- 4 files changed, 5 insertions(+), 9 deletions(-) diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt index a1e688577..e3eb2d8c8 100644 --- a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt +++ b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt @@ -501,10 +501,8 @@ class BarLineChartTouchListener( chart.zoom(scaleX, scaleY, trans.x, trans.y) - if (chart.isLogEnabled) Log.i( - "BarlineChartTouch", ("Double-Tap, Zooming In, x: " + trans.x + ", y: " - + trans.y) - ) + if (chart.isLogEnabled) + Log.i("BarlineChartTouch", "Double-Tap, Zooming In, x: ${trans.x} y: ${trans.y}") onChartGestureListener?.onChartScale(e, scaleX, scaleY) diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/OnDrawListener.kt b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/OnDrawListener.kt index 151bc2688..d1e5a0ea4 100644 --- a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/OnDrawListener.kt +++ b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/OnDrawListener.kt @@ -16,7 +16,7 @@ interface OnDrawListener { fun onEntryAdded(entry: Entry) /** - * Called whenever an entry is moved by the user after beeing highlighted + * Called whenever an entry is moved by the user after being highlighted */ fun onEntryMoved(entry: Entry) diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt b/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt index 20d6480fb..779871098 100644 --- a/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt +++ b/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt @@ -191,8 +191,7 @@ open class BarChartRenderer( } if (!isSingleColor) { - // Set the color for the currently drawn value. If the index - // is out of bounds, reuse colors. + // Set the color for the currently drawn value. If the index is out of bounds, reuse colors. paintRender.color = dataSet.getColorByIndex(pos) } diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.kt b/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.kt index 826442dd9..57d9c17a8 100644 --- a/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.kt +++ b/MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.kt @@ -322,8 +322,7 @@ open class LineChartRenderer( if (!viewPortHandler.isInBoundsRight(firstCoordinateX)) break - // make sure the lines don't do shitty things outside - // bounds + // make sure the lines don't do shitty things outside bounds if (!viewPortHandler.isInBoundsLeft(lastCoordinateX) || !viewPortHandler.isInBoundsTop( max( firstCoordinateY.toDouble(), From f6e4976702029c99c8af84b3c01456b2514fe5ec Mon Sep 17 00:00:00 2001 From: Hannes Achleitner Date: Wed, 24 Dec 2025 11:10:24 +0100 Subject: [PATCH 2/2] Remove unneded variance --- .../mikephil/charting/listener/BarLineChartTouchListener.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt index e3eb2d8c8..c3a2f9996 100644 --- a/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt +++ b/MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt @@ -25,11 +25,11 @@ import kotlin.math.sqrt */ @Suppress("MemberVisibilityCanBePrivate") class BarLineChartTouchListener( - chart: BarLineChartBase>>, + chart: BarLineChartBase>>, touchMatrix: Matrix, dragTriggerDistance: Float ) : - ChartTouchListener>>>(chart) { + ChartTouchListener>>>(chart) { /** * the original touch-matrix from the chart */