Don't save context

Author: hannesa2

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/DynamicalAddingActivity.java

@@ -70,7 +70,6 @@ private void addEntry() {
             data.addDataSet(set);
         }
 
-        // choose a random dataSet
         int randomDataSetIndex = (int) (Math.random() * data.getDataSetCount());
         ILineDataSet randomSet = data.getDataSetByIndex(randomDataSetIndex);
         float value = (float) (Math.random() * 50) + 50f * (randomDataSetIndex + 1);

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/BarChartFrag.java

@@ -45,7 +45,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         chart.setDrawGridBackground(false);
         chart.setDrawBarShadow(false);
 
-        Typeface tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Light.ttf");
+        Typeface tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Light.ttf");
 
         chart.setData(generateBarData(1, 20000, 12));
 

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/ComplexityFragment.java

@@ -37,7 +37,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         chart.setData(getComplexity());
         chart.animateX(3000);
 
-        Typeface tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Light.ttf");
+        Typeface tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Light.ttf");
 
         Legend l = chart.getLegend();
         l.setTypeface(tf);

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/PieChartFrag.java

@@ -33,7 +33,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         chart = v.findViewById(R.id.pieChart1);
         chart.getDescription().setEnabled(false);
 
-        Typeface tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Light.ttf");
+        Typeface tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Light.ttf");
 
         chart.setCenterTextTypeface(tf);
         chart.setCenterText(generateCenterText());

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/ScatterChartFrag.java

@@ -34,7 +34,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         chart = v.findViewById(R.id.scatterChart1);
         chart.getDescription().setEnabled(false);
 
-        Typeface tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Light.ttf");
+        Typeface tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Light.ttf");
 
         MyMarkerView mv = new MyMarkerView(getActivity(), R.layout.custom_marker_view);
         mv.setChartView(chart); // For bounds control

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/SimpleFragment.java

@@ -1,6 +1,5 @@
 package com.xxmassdeveloper.mpchartexample.fragments;
 
-import android.content.Context;
 import android.graphics.Color;
 import android.graphics.Typeface;
 import android.os.Bundle;
@@ -34,21 +33,14 @@
 public abstract class SimpleFragment extends Fragment {
 
     private Typeface tf;
-    protected Context context;
-
-    @Override
-    public void onAttach(Context context) {
-        super.onAttach(context);
-        this.context = context;
-    }
 
     public SimpleFragment() {
 
     }
 
     @Override
     public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
-        tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Regular.ttf");
+        tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Regular.ttf");
         return super.onCreateView(inflater, container, savedInstanceState);
     }
 
@@ -130,8 +122,8 @@ protected PieData generatePieData() {
     protected LineData generateLineData() {
 
         ArrayList<ILineDataSet> sets = new ArrayList<>();
-        LineDataSet ds1 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "sine.txt"), "Sine function");
-        LineDataSet ds2 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "cosine.txt"), "Cosine function");
+        LineDataSet ds1 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "sine.txt"), "Sine function");
+        LineDataSet ds2 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "cosine.txt"), "Cosine function");
 
         ds1.setLineWidth(2f);
         ds2.setLineWidth(2f);
@@ -155,10 +147,10 @@ protected LineData getComplexity() {
 
         ArrayList<ILineDataSet> sets = new ArrayList<>();
 
-        LineDataSet ds1 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "n.txt"), "O(n)");
-        LineDataSet ds2 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "nlogn.txt"), "O(nlogn)");
-        LineDataSet ds3 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "square.txt"), "O(n\u00B2)");
-        LineDataSet ds4 = new LineDataSet(FileUtils.loadEntriesFromAssets(context.getAssets(), "three.txt"), "O(n\u00B3)");
+        LineDataSet ds1 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "n.txt"), "O(n)");
+        LineDataSet ds2 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "nlogn.txt"), "O(nlogn)");
+        LineDataSet ds3 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "square.txt"), "O(n\u00B2)");
+        LineDataSet ds4 = new LineDataSet(FileUtils.loadEntriesFromAssets(requireContext().getAssets(), "three.txt"), "O(n\u00B3)");
 
         ds1.setColor(ColorTemplate.VORDIPLOM_COLORS[0]);
         ds2.setColor(ColorTemplate.VORDIPLOM_COLORS[1]);

MPChartExample/src/main/java/com/xxmassdeveloper/mpchartexample/fragments/SineCosineFragment.java

@@ -37,7 +37,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         chart.setData(generateLineData());
         chart.animateX(3000);
 
-        Typeface tf = Typeface.createFromAsset(context.getAssets(), "OpenSans-Light.ttf");
+        Typeface tf = Typeface.createFromAsset(requireContext().getAssets(), "OpenSans-Light.ttf");
 
         Legend l = chart.getLegend();
         l.setTypeface(tf);