Skip to content

Commit 1af8154

Browse files
apartsinclaude
andcommitted
fix: resolve CI failures — npm ci lockfile + TypeScript lint errors
- Root cause: workspace config in root package.json caused npm ci in src/typescript/ to look for root lockfile (which was gitignored) - Track root package-lock.json and run npm ci from root in all workflows - Fix TypeScript lint: add missing Middleware/MiddlewareStack imports in src/index.ts convenience layer - Update .gitignore to allow root package-lock.json - All 1,893 tests pass (1,180 Python + 713 TypeScript) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d3fac88 commit 1af8154

8 files changed

Lines changed: 5404 additions & 8 deletions

File tree

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
with:
4343
node-version: "20"
4444
- name: Install dependencies
45-
run: cd src/typescript && npm ci
45+
run: npm ci
4646
- name: Run tests with coverage
4747
run: cd src/typescript && npx jest --coverage --coverageReporters=text --coverageReporters=cobertura
4848
- name: Upload TypeScript coverage

.github/workflows/publish-npm.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ jobs:
2727

2828
- name: Install and build
2929
run: |
30-
cd src/typescript
3130
npm ci
32-
npm run build
31+
cd src/typescript && npm run build
3332
3433
- name: Run tests
3534
run: cd src/typescript && npm test

.github/workflows/publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ jobs:
5454
node-version: "20"
5555
registry-url: "https://registry.npmjs.org"
5656
- name: Install dependencies
57-
working-directory: src/typescript
5857
run: npm ci
5958
- name: Build
6059
working-directory: src/typescript

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ jobs:
4646
4747
- name: Build TypeScript package
4848
run: |
49-
cd src/typescript
5049
npm ci
50+
cd src/typescript
5151
npm run build
5252
npm pack
5353

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Python type check (mypy)
2323
run: pip install mypy && cd src/python && mypy modelmesh --ignore-missing-imports --no-error-summary || true
2424
- name: TypeScript lint (tsc --noEmit)
25-
run: cd src/typescript && npm ci && npm run lint
25+
run: npm ci && npm run --workspace src/typescript lint
2626
- name: Version consistency check
2727
run: |
2828
PY_VER=$(grep '^version' src/python/pyproject.toml | head -1 | sed 's/.*"\(.*\)"/\1/')
@@ -55,7 +55,7 @@ jobs:
5555
- uses: actions/setup-node@v4
5656
with:
5757
node-version: ${{ matrix.node-version }}
58-
- run: cd src/typescript && npm ci && npm test
58+
- run: npm ci && npm test --workspace src/typescript
5959

6060
docker:
6161
name: Docker Build

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ Thumbs.db
3535
# Node.js
3636
node_modules/
3737
*.tgz
38-
package-lock.json
38+
**/node_modules/**/package-lock.json
39+
!/package-lock.json
3940
!/src/typescript/package-lock.json
4041

4142
# Test output

0 commit comments

Comments
 (0)