-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathvalidation_test.go
More file actions
374 lines (313 loc) · 8.79 KB
/
validation_test.go
File metadata and controls
374 lines (313 loc) · 8.79 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
package anet
import (
"io"
"net"
"sync/atomic"
"testing"
"time"
"github.com/stretchr/testify/require"
)
// timeoutError implements net.Error with Timeout() returning true.
type timeoutError struct{}
// mockValidationConn is a test connection that can simulate various states.
type mockValidationConn struct {
closed atomic.Bool
readShouldError bool
readError error
data []byte
readPos int
}
// mockBasicItem is a PoolItem that doesn't support deadlines.
type mockBasicItem struct {
valid bool
}
func (e *timeoutError) Error() string { return "timeout" }
func (e *timeoutError) Timeout() bool { return true }
func (e *timeoutError) Temporary() bool { return false }
func (m *mockBasicItem) Close() error {
return nil
}
func newMockValidationConn() *mockValidationConn {
return &mockValidationConn{
data: []byte{}, // Default to empty data (idle connection)
}
}
func (m *mockValidationConn) Read(b []byte) (int, error) {
if m.closed.Load() {
return 0, io.EOF
}
if m.readShouldError {
return 0, m.readError
}
if m.readPos >= len(m.data) {
// Simulate timeout for validation - create a proper timeout error
return 0, &timeoutError{}
}
n := copy(b, m.data[m.readPos:])
m.readPos += n
return n, nil
}
func (m *mockValidationConn) Write(b []byte) (int, error) {
if m.closed.Load() {
return 0, io.EOF
}
return len(b), nil
}
func (m *mockValidationConn) Close() error {
m.closed.Store(true)
return nil
}
func (m *mockValidationConn) SetDeadline(_ time.Time) error {
return nil
}
func (m *mockValidationConn) SetReadDeadline(_ time.Time) error {
return nil
}
func (m *mockValidationConn) SetWriteDeadline(_ time.Time) error {
return nil
}
func (m *mockValidationConn) LocalAddr() net.Addr {
return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 0}
}
func (m *mockValidationConn) RemoteAddr() net.Addr {
return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 8080}
}
func TestConnectionValidation(t *testing.T) {
t.Parallel()
tests := []struct {
name string
strategy ValidationStrategy
setup func() PoolItem
expected bool
}{
{
name: "ValidationNone should always pass",
strategy: ValidationNone,
setup: func() PoolItem {
conn := newMockValidationConn()
conn.closed.Store(true) // Even closed connections should pass
return conn
},
expected: true,
},
{
name: "ValidationRead with healthy connection",
strategy: ValidationRead,
setup: func() PoolItem {
return newMockValidationConn()
},
expected: true,
},
{
name: "ValidationRead with closed connection",
strategy: ValidationRead,
setup: func() PoolItem {
conn := newMockValidationConn()
conn.closed.Store(true)
return conn
},
expected: false,
},
{
name: "ValidationRead with timeout (healthy)",
strategy: ValidationRead,
setup: func() PoolItem {
conn := newMockValidationConn()
conn.readPos = len(conn.data) // Force timeout
return conn
},
expected: true, // Timeout is expected for healthy connections
},
{
name: "ValidationPing with healthy connection",
strategy: ValidationPing,
setup: func() PoolItem {
return newMockValidationConn()
},
expected: true,
},
{
name: "Basic item with ValidationRead",
strategy: ValidationRead,
setup: func() PoolItem {
return &mockBasicItem{valid: true}
},
expected: true, // Should fallback to basic validation
},
{
name: "Nil connection",
strategy: ValidationRead,
setup: func() PoolItem {
return nil
},
expected: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
config := DefaultPoolConfig()
config.ValidationStrategy = tt.strategy
config.ValidationTimeout = 100 * time.Millisecond
config.MaxValidationAttempts = 2
p := &pool{
config: config,
}
item := tt.setup()
result := p.validateConnection(item)
require.Equal(t, tt.expected, result)
})
}
}
func TestValidationStrategies(t *testing.T) {
t.Parallel()
t.Run("ValidationPing with non-TCP connection", func(t *testing.T) {
t.Parallel()
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationPing
p := &pool{config: config}
// Use basic item that doesn't implement net.Conn
item := &mockBasicItem{valid: true}
err := p.validatePing(item)
require.NoError(t, err) // Should return nil for non-TCP connections
})
t.Run("ValidationRead with retry logic", func(t *testing.T) {
t.Parallel()
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationRead
config.MaxValidationAttempts = 3
p := &pool{config: config}
// Test that validation respects MaxValidationAttempts
// Use a connection that always fails to verify retry count
conn := newMockValidationConn()
conn.readShouldError = true
conn.readError = io.ErrUnexpectedEOF
result := p.validateConnectionWithStrategy(conn)
require.False(t, result) // Should fail after all attempts
// Test successful validation on healthy connection
healthyConn := newMockValidationConn()
result2 := p.validateConnectionWithStrategy(healthyConn)
require.True(t, result2) // Should succeed immediately
})
}
func TestPoolValidationIntegration(t *testing.T) {
t.Parallel()
factory := func(_ string) (PoolItem, error) {
return newMockValidationConn(), nil
}
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationRead
config.ValidationInterval = 50 * time.Millisecond
config.ValidationTimeout = 100 * time.Millisecond
pool := NewPool(5, factory, "test:8080", config)
defer pool.Close()
// Get a connection and put it back
item, err := pool.Get()
require.NoError(t, err)
require.NotNil(t, item)
pool.Put(item)
// Wait for validation cycle
time.Sleep(100 * time.Millisecond)
// Pool should still work after validation
item2, err := pool.Get()
require.NoError(t, err)
require.NotNil(t, item2)
}
func TestValidationSubset(t *testing.T) {
t.Parallel()
// Create mock connections with different states
factory := func(_ string) (PoolItem, error) {
return newMockValidationConn(), nil
}
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationRead
config.ValidationTimeout = 50 * time.Millisecond
p := NewPool(10, factory, "test:8080", config)
defer p.Close()
poolImpl, ok := p.(*pool)
require.True(t, ok)
// Fill pool with connections
var items []PoolItem
for i := 0; i < 5; i++ {
item, err := p.Get()
require.NoError(t, err)
items = append(items, item)
}
// Return all items
for _, item := range items {
p.Put(item)
}
// Break one connection
if len(items) > 0 {
if mockConn, ok := items[0].(*mockValidationConn); ok {
mockConn.closed.Store(true)
}
}
// Run validation subset
poolImpl.validateConnectionSubset()
// Pool should still be functional
item, err := p.Get()
require.NoError(t, err)
require.NotNil(t, item)
}
func TestValidationWithNilConfig(t *testing.T) {
t.Parallel()
factory := func(_ string) (PoolItem, error) {
return newMockValidationConn(), nil
}
// Pool should use default config when nil is passed
poolInstance := NewPool(5, factory, "test:8080", nil)
defer poolInstance.Close()
item, err := poolInstance.Get()
require.NoError(t, err)
require.NotNil(t, item)
poolInstance.Put(item)
// Validate that default config is used
poolImpl, ok := poolInstance.(*pool)
require.True(t, ok)
require.Equal(t, ValidationRead, poolImpl.config.ValidationStrategy)
require.Equal(t, 1*time.Second, poolImpl.config.ValidationTimeout)
require.Equal(t, 3, poolImpl.config.MaxValidationAttempts)
}
func BenchmarkConnectionValidation(b *testing.B) {
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationRead
config.ValidationTimeout = 10 * time.Millisecond
p := &pool{config: config}
benchmarks := []struct {
name string
strategy ValidationStrategy
}{
{"ValidationNone", ValidationNone},
{"ValidationPing", ValidationPing},
{"ValidationRead", ValidationRead},
}
for _, bm := range benchmarks {
b.Run(bm.name, func(b *testing.B) {
p.config.ValidationStrategy = bm.strategy
b.ResetTimer()
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
conn := newMockValidationConn()
p.validateConnection(conn)
_ = conn.Close()
}
})
})
}
}
func TestValidationTimeout(t *testing.T) {
t.Parallel()
config := DefaultPoolConfig()
config.ValidationStrategy = ValidationRead
config.ValidationTimeout = 10 * time.Millisecond // Very short timeout
p := &pool{config: config}
// Create connection that will cause timeout
conn := newMockValidationConn()
conn.readPos = len(conn.data) // Force timeout behavior
start := time.Now()
result := p.validateConnection(conn)
elapsed := time.Since(start)
require.True(t, result) // Timeout should be considered valid
require.Less(t, elapsed, 100*time.Millisecond) // Should timeout quickly
}