Fix crash when running JsonSerializer::closeNested() while in write mode#187
Merged
Conversation
2a7b8b3 to
0f31d75
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 70 70
Lines 1242 1242
Branches 383 383
=======================================
Hits 1023 1023
Misses 148 148
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e23733 to
f093c24
Compare
f093c24 to
b20713b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FIx a crash occuring when calling JsonSerializer::closeNested() while writing data to the serializer due to a missing verification.
Also introduce new
isArrayEndandgetArraySizehelper methods.What type of PR is this? (check all applicable)
Added/updated tests?