From 37eb7fd8ed83fa213dceda61abec1a3adc1f431e Mon Sep 17 00:00:00 2001 From: TheAncientAnimal <78173928+TheAncientAnimal@users.noreply.github.com> Date: Thu, 28 Jan 2021 15:41:27 -0500 Subject: [PATCH] Update ConfigMgrClientHealth.ps1 Changed client version variables into a Version type for more accurate version comparisons. --- ConfigMgrClientHealth.ps1 | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ConfigMgrClientHealth.ps1 b/ConfigMgrClientHealth.ps1 index 9dd2822..3279962 100644 --- a/ConfigMgrClientHealth.ps1 +++ b/ConfigMgrClientHealth.ps1 @@ -1255,11 +1255,11 @@ Begin { Function Test-ClientVersion { Param([Parameter(Mandatory=$true)]$Log) - $ClientVersion = Get-XMLConfigClientVersion + [Version]$ClientVersion = Get-XMLConfigClientVersion [String]$ClientAutoUpgrade = Get-XMLConfigClientAutoUpgrade $ClientAutoUpgrade = $ClientAutoUpgrade.ToLower() - $installedVersion = Get-ClientVersion - $log.ClientVersion = $installedVersion + [Version]$installedVersion = Get-ClientVersion + $log.ClientVersion = $installedVersion.ToString() if ($installedVersion -ge $ClientVersion) { $text = 'ConfigMgr Client version is: ' +$installedVersion + ': OK' @@ -3467,10 +3467,10 @@ Process { $log.CacheSize = Get-ClientCache # Verify that installed client version is now equal or better that minimum required client version - $NewClientVersion = Get-ClientVersion - $MinimumClientVersion = Get-XMLConfigClientVersion + [Version]$NewClientVersion = Get-ClientVersion + [Version]$MinimumClientVersion = Get-XMLConfigClientVersion - if ( $NewClientVersion -lt $MinimumClientVersion) { + if ($NewClientVersion -lt $MinimumClientVersion) { # ConfigMgr client version is still not at expected level. # Log for now, remediation is comming $Log.ClientInstalledReason += " Upgrade failed."