Removing unneeded tests

Author: heinrichb

pkg/config/config_test.go

@@ -9,17 +9,17 @@ import (
 )
 
 /*
-TestLoadMissingFile ensures Load correctly returns an error when the config file does not exist.
+TestLoadMissingFile ensures that loading a non-existent config file returns an error.
 */
 func TestLoadMissingFile(t *testing.T) {
-	_, err := Load("nonexistent_config.json")
+	_, err := Load("nonexistent.json")
 	if err == nil {
-		t.Fatalf("Expected error for missing config file, got nil")
+		t.Fatalf("Expected error for missing config file, but got nil")
 	}
 }
 
 /*
-TestLoadUnreadableFile ensures Load correctly returns an error when the config file is unreadable.
+TestLoadUnreadableFile ensures that loading an unreadable file returns an error.
 */
 func TestLoadUnreadableFile(t *testing.T) {
 	tmpFile, err := os.CreateTemp("", "unreadable_config_*.json")
@@ -28,71 +28,65 @@ func TestLoadUnreadableFile(t *testing.T) {
 	}
 	defer os.Remove(tmpFile.Name())
 
-	if err := os.Chmod(tmpFile.Name(), 0000); err != nil {
-		t.Fatalf("Failed to set file permissions: %v", err)
-	}
+	// Make the file unreadable
+	os.Chmod(tmpFile.Name(), 0000)
 	defer os.Chmod(tmpFile.Name(), 0644) // Restore permissions after test
 
 	_, err = Load(tmpFile.Name())
 	if err == nil {
-		t.Fatalf("Expected error for unreadable file, got nil")
+		t.Fatalf("Expected error for unreadable file, but got nil")
 	}
 }
 
 /*
-TestLoadInvalidJSONFormat ensures Load correctly returns an error for malformed JSON.
+TestLoadInvalidJSONFormat ensures that loading a file with invalid JSON format returns an error.
 */
 func TestLoadInvalidJSONFormat(t *testing.T) {
-	tmpFile, err := os.CreateTemp("", "invalid_json_*.json")
+	tmpFile, err := os.CreateTemp("", "invalid_config_*.json")
 	if err != nil {
 		t.Fatalf("Failed to create temp file: %v", err)
 	}
 	defer os.Remove(tmpFile.Name())
 
-	// Invalid JSON (missing closing brace)
-	invalidJSON := `{"url": {"base": "http://example.org"`
+	invalidJSON := `{"url": {"base": "http://example.org"` // Missing closing brace
 	if _, err := tmpFile.Write([]byte(invalidJSON)); err != nil {
 		t.Fatalf("Failed to write to temp file: %v", err)
 	}
 	tmpFile.Close()
 
 	_, err = Load(tmpFile.Name())
 	if err == nil {
-		t.Fatalf("Expected error for malformed JSON, got nil")
+		t.Fatalf("Expected error for invalid JSON format, but got nil")
 	}
 }
 
 /*
-TestLoadVerboseMode ensures that verbose mode triggers PrintNonEmptyFields.
+TestLoadVerboseMode ensures that verbose mode prints additional output.
 */
 func TestLoadVerboseMode(t *testing.T) {
 	Verbose = true
 	defer func() { Verbose = false }()
 
-	tmpFile, err := os.CreateTemp("", "verbose_config_*.json")
+	tmpFile, err := os.CreateTemp("", "valid_config_*.json")
 	if err != nil {
 		t.Fatalf("Failed to create temp file: %v", err)
 	}
 	defer os.Remove(tmpFile.Name())
 
-	validJSON := `{"url": {"base": "http://example.org"}}`
+	validJSON := `{"url": {"base": "http://example.org", "routes": ["/test"], "includeBase": true}}`
 	if _, err := tmpFile.Write([]byte(validJSON)); err != nil {
 		t.Fatalf("Failed to write to temp file: %v", err)
 	}
 	tmpFile.Close()
 
-	cfg, err := Load(tmpFile.Name())
+	_, err = Load(tmpFile.Name())
 	if err != nil {
-		t.Fatalf("Expected valid config, got error: %v", err)
-	}
-
-	if cfg.URL.Base != "http://example.org" {
-		t.Errorf("Expected Base URL 'http://example.org', got '%s'", cfg.URL.Base)
+		t.Fatalf("Expected successful load with verbose mode, but got error: %v", err)
 	}
 }
 
 /*
-TestOverrideWithInvalidField ensures that OverrideWithCLI skips invalid fields safely.
+TestOverrideWithInvalidField ensures that OverrideWithCLI correctly skips invalid fields.
 */
 func TestOverrideWithInvalidField(t *testing.T) {
 	cfg := &Config{}
@@ -101,9 +95,8 @@ func TestOverrideWithInvalidField(t *testing.T) {
 	overrides := Config{}
 	field := reflect.ValueOf(&overrides).Elem().FieldByName("InvalidField")
 
-	// Ensure the field exists and can be modified
 	if field.IsValid() && field.CanSet() {
-		field.Set(reflect.ValueOf(42)) // Invalid field
+		field.Set(reflect.ValueOf(42))
 	}
 
 	defer func() {
@@ -116,64 +109,7 @@ func TestOverrideWithInvalidField(t *testing.T) {
 }
 
 /*
-TestOverrideWithInvalidNestedField ensures that OverrideWithCLI skips invalid nested fields safely.
-*/
-func TestOverrideWithInvalidNestedField(t *testing.T) {
-	cfg := &Config{}
-	cfg.ApplyDefaults()
-
-	overrides := Config{}
-
-	// Get the field reference
-	field := reflect.ValueOf(&overrides).Elem().FieldByName("URL")
-
-	// Ensure the field exists and is of type struct before attempting an invalid override
-	if field.IsValid() && field.Kind() == reflect.Struct {
-		defer func() {
-			if r := recover(); r != nil {
-				t.Fatalf("Expected safe handling of invalid nested fields, but got panic: %v", r)
-			}
-		}()
-
-		// Try setting an invalid value (int) but ensure it's prevented before setting
-		invalidValue := reflect.ValueOf(42)
-		if field.CanSet() && field.Kind() == invalidValue.Kind() { // Ensure types match
-			field.Set(invalidValue) // This should NOT execute due to validation.
-		}
-	}
-
-	// Ensure the override function does not crash on incorrect input
-	cfg.OverrideWithCLI(overrides)
-}
-
-/*
-TestOverrideWithValidSubField ensures that OverrideWithCLI correctly overrides valid subfields.
-*/
-func TestOverrideWithValidSubField(t *testing.T) {
-	cfg := &Config{}
-	cfg.ApplyDefaults()
-
-	overrides := Config{
-		ParseRules: struct {
-			Title           string `json:"title,omitempty"`
-			MetaDescription string `json:"metaDescription,omitempty"`
-			ArticleContent  string `json:"articleContent,omitempty"`
-			Author          string `json:"author,omitempty"`
-			DatePublished   string `json:"datePublished,omitempty"`
-		}{
-			Title: "New Title",
-		},
-	}
-
-	cfg.OverrideWithCLI(overrides)
-
-	if cfg.ParseRules.Title != "New Title" {
-		t.Errorf("Expected Title to be 'New Title', got '%s'", cfg.ParseRules.Title)
-	}
-}
-
-/*
-TestOverrideWithEmptySlices ensures that OverrideWithCLI skips empty slice values.
+TestOverrideWithEmptySlices ensures that OverrideWithCLI skips overriding fields with empty slices.
 */
 func TestOverrideWithEmptySlices(t *testing.T) {
 	cfg := &Config{}
@@ -192,12 +128,12 @@ func TestOverrideWithEmptySlices(t *testing.T) {
 	cfg.OverrideWithCLI(overrides)
 
 	if len(cfg.URL.Routes) == 0 {
-		t.Errorf("Expected Routes to remain unchanged, but they were overridden with an empty slice.")
+		t.Errorf("Expected routes to remain unchanged, but they were overridden with an empty slice.")
 	}
 }
 
 /*
-TestOverrideWithValidFields ensures that OverrideWithCLI correctly applies non-zero overrides.
+TestOverrideWithValidFields ensures that OverrideWithCLI correctly applies valid overrides.
 */
 func TestOverrideWithValidFields(t *testing.T) {
 	cfg := &Config{}
@@ -210,18 +146,18 @@ func TestOverrideWithValidFields(t *testing.T) {
 			RetryAttempts int     `json:"retryAttempts"`
 			UserAgent     string  `json:"userAgent"`
 		}{
-			MaxDepth:  5,
-			RateLimit: 2.5,
+			MaxDepth:  10,
+			RateLimit: 3.5,
 		},
 	}
 
 	cfg.OverrideWithCLI(overrides)
 
-	if cfg.ScrapingOptions.MaxDepth != 5 {
-		t.Errorf("Expected MaxDepth to be overridden to 5, got '%d'", cfg.ScrapingOptions.MaxDepth)
+	if cfg.ScrapingOptions.MaxDepth != 10 {
+		t.Errorf("Expected MaxDepth to be overridden to 10, got %d", cfg.ScrapingOptions.MaxDepth)
 	}
 
-	if cfg.ScrapingOptions.RateLimit != 2.5 {
-		t.Errorf("Expected RateLimit to be overridden to 2.5, got '%f'", cfg.ScrapingOptions.RateLimit)
+	if cfg.ScrapingOptions.RateLimit != 3.5 {
+		t.Errorf("Expected RateLimit to be overridden to 3.5, got %f", cfg.ScrapingOptions.RateLimit)
 	}
 }