Skip to content

Commit 5361880

Browse files
authored
[MFT] shorten message boxes on occupancy summaries (#2651)
* changed message for medium quality * changed messages for medium quality * adjust quality message width * capitalise quality
1 parent dc3f1aa commit 5361880

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

Modules/MFT/src/QcMFTClusterCheck.cxx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -306,32 +306,32 @@ void QcMFTClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality chec
306306

307307
if (mo->getName().find("mClusterOccupancySummary") != std::string::npos) {
308308
auto* hOccupancySummary = dynamic_cast<TH2F*>(mo->getObject());
309-
TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB");
310-
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB");
309+
TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB");
310+
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB");
311311
hOccupancySummary->GetListOfFunctions()->Add(msg1);
312312
hOccupancySummary->GetListOfFunctions()->Add(msg2);
313313
msg1->SetName(Form("%s_msg1", mo->GetName()));
314314
msg2->SetName(Form("%s_msg2", mo->GetName()));
315315
if (checkResult == Quality::Good) {
316316
LOG(info) << "Quality::Good";
317317
msg1->Clear();
318-
msg1->AddText("Quality Good");
318+
msg1->AddText("Quality GOOD");
319319
msg1->SetFillColor(kGreen);
320320
msg2->Clear();
321321
msg2->AddText("No action needed");
322322
msg2->SetFillColor(kGreen);
323323
} else if (checkResult == Quality::Medium) {
324324
LOG(info) << "Quality::Medium";
325325
msg1->Clear();
326-
msg1->AddText("Quality medium");
326+
msg1->AddText("Quality MEDIUM");
327327
msg1->SetFillColor(kOrange);
328328
msg2->Clear();
329-
msg2->AddText("Write a logbook entry tagging MFT");
329+
msg2->AddText("Refer to QC instructions");
330330
msg2->SetFillColor(kOrange);
331331
} else if (checkResult == Quality::Bad) {
332332
LOG(info) << "Quality::Bad";
333333
msg1->Clear();
334-
msg1->AddText("Quality bad");
334+
msg1->AddText("Quality BAD");
335335
msg1->SetFillColor(kRed);
336336
msg2->Clear();
337337
msg2->AddText("Call the on-call!");

Modules/MFT/src/QcMFTDigitCheck.cxx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
444444
msg->AddText("No action needed");
445445
} else if (mQualityMedium) {
446446
QualityColor = kOrange;
447-
msg->AddText("Write a logbook entry tagging MFT");
447+
msg->AddText("Refer to QC instructions");
448448
} else if (mQualityBad) {
449449
QualityColor = kRed;
450450
msg->AddText("Call the on-call!");
@@ -479,16 +479,16 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
479479

480480
if (mo->getName().find("mDigitOccupancySummary") != std::string::npos) {
481481
auto* hDigitOccupancySummary = dynamic_cast<TH2F*>(mo->getObject());
482-
TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB");
483-
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB");
482+
TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB");
483+
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB");
484484
hDigitOccupancySummary->GetListOfFunctions()->Add(msg1);
485485
hDigitOccupancySummary->GetListOfFunctions()->Add(msg2);
486486
msg1->SetName(Form("%s_msg", mo->GetName()));
487487
msg2->SetName(Form("%s_msg2", mo->GetName()));
488488
if (checkResult == Quality::Good) {
489489
LOG(info) << "Quality::Good";
490490
msg1->Clear();
491-
msg1->AddText("Quality Good");
491+
msg1->AddText("Quality GOOD");
492492
msg1->SetFillColor(kGreen);
493493
msg1->Draw();
494494
msg2->Clear();
@@ -498,17 +498,17 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
498498
} else if (checkResult == Quality::Medium) {
499499
LOG(info) << "Quality::Medium";
500500
msg1->Clear();
501-
msg1->AddText("Quality medium");
501+
msg1->AddText("Quality MEDIUM");
502502
msg1->SetFillColor(kOrange);
503503
msg1->Draw();
504504
msg2->Clear();
505-
msg2->AddText("Write a logbook entry tagging MFT");
505+
msg2->AddText("Refer to QC instructions");
506506
msg2->SetFillColor(kOrange);
507507
msg2->Draw();
508508
} else if (checkResult == Quality::Bad) {
509509
LOG(info) << "Quality::Bad";
510510
msg1->Clear();
511-
msg1->AddText("Quality bad");
511+
msg1->AddText("Quality BAD");
512512
msg1->SetFillColor(kRed);
513513
msg1->Draw();
514514
msg2->Clear();

0 commit comments

Comments
 (0)