[Infrastructure,Tools,Common] Avoid having intermediary vectors for the NN-based TPC PID #29124
ktfAnnotations
10 errors, 1 warning, and 2 notices
|
[name/configurable]:
Common/Tools/PID/pidTPCModule.h#L110
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
Common/Tools/PID/pidTPCModule.h#L109
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
Common/Tools/PID/pidTPCModule.h#L95
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
Common/Tools/PID/pidTPCModule.h#L92
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L536
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L527
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L519
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L471
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L466
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
Common/Tools/PID/pidTPCModule.h#L463
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: thollander/actions-comment-pull-request@v3. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|