Skip to content

Commit 90d871a

Browse files
knopers8teo
authored andcommitted
[core] Indicate run type in GRP objects
1 parent 3c8ee96 commit 90d871a

1 file changed

Lines changed: 15 additions & 11 deletions

File tree

core/integration/ccdb/plugin.go

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -191,17 +191,23 @@ func (p *Plugin) NewCcdbGrpWriteCommand(grp *GeneralRunParameters, ccdbUrl strin
191191
// o2-ecs-grp-create -h
192192
//Create GRP-ECS object and upload to the CCDB
193193
//Usage:
194-
// o2-ecs-grp-create
195194
// -h [ --help ] Print this help message
196195
// -p [ --period ] arg data taking period
197196
// -r [ --run ] arg run number
197+
// -t [ --run-type ] arg (=0) run type
198198
// -n [ --hbf-per-tf ] arg (=128) number of HBFs per TF
199199
// -d [ --detectors ] arg (=all) comma separated list of detectors
200-
// -c [ --continuous ] arg (=ITS,TPC,TOF,MFT,MCH,MID,ZDC,FT0,FV0,FDD,CTP) comma separated list of detectors in continuous readout mode
201-
// -t [ --triggering ] arg (=FT0,FV0) comma separated list of detectors providing a trigger
200+
// -c [ --continuous ] arg (=ITS,TPC,TOF,MFT,MCH,MID,ZDC,FT0,FV0,FDD,CTP)
201+
// comma separated list of detectors in
202+
// continuous readout mode
203+
// -g [ --triggering ] arg (=FT0,FV0) comma separated list of detectors
204+
// providing a trigger
202205
// -s [ --start-time ] arg (=0) run start time in ms, now() if 0
203-
// -e [ --end-time ] arg (=0) run end time in ms, start-time+3days is used if 0
204-
// --ccdb-server arg (=http://alice-ccdb.cern.ch) CCDB server for upload, local file if empty
206+
// -e [ --end-time ] arg (=0) run end time in ms, start-time+3days is
207+
// used if 0
208+
// --ccdb-server arg (=http://alice-ccdb.cern.ch)
209+
// CCDB server for upload, local file if
210+
// empty
205211

206212
cmd = "source /etc/profile.d/o2.sh && o2-ecs-grp-create"
207213
if len(grp.lhcPeriod) == 0 {
@@ -215,19 +221,17 @@ func (p *Plugin) NewCcdbGrpWriteCommand(grp *GeneralRunParameters, ccdbUrl strin
215221
if grp.hbfPerTf != 0 {
216222
cmd += " -n " + strconv.FormatUint(uint64(grp.hbfPerTf), 10)
217223
}
218-
// TODO enable once PR#8082 to O2 is at P2
219-
//if grp.runType != runtype.NONE {
220-
// cmd += " --run-type " + grp.runType.String()
221-
//}
224+
if grp.runType != runtype.NONE {
225+
cmd += " -t " + strconv.Itoa(int(grp.runType))
226+
}
222227
if len(grp.detectors) != 0 {
223228
cmd += " -d \"" + strings.Join(grp.detectors, ",") + "\""
224229
}
225230
if len(grp.continuousReadoutDetectors) != 0 {
226231
cmd += " -c \"" + strings.Join(grp.continuousReadoutDetectors, ",") + "\""
227232
}
228233
if len(grp.triggeringDetectors) != 0 {
229-
// keeping the full argument until the conflict between '-t's of triggering and run-type is resolved
230-
cmd += " --triggering \"" + strings.Join(grp.triggeringDetectors, ",") + "\""
234+
cmd += " -g \"" + strings.Join(grp.triggeringDetectors, ",") + "\""
231235
}
232236
if len(grp.startTimeMs) > 0 {
233237
cmd += " -s " + grp.startTimeMs

0 commit comments

Comments
 (0)