Skip to content

Commit a593614

Browse files
committed
Code review: minor fixes
1 parent 95f5ba4 commit a593614

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

include/graphblas/bsp/collectives.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ namespace grb {
367367
* This function may place an alloc of \f$ P\mathit{sizeof}(IOType) \f$ bytes
368368
* if the internal buffer was not sufficiently large.
369369
*
370-
* @tparam Operator A binary operator that must never generate no-ops.
370+
* @tparam Operator A binary operator.
371371
*/
372372
template<
373373
Descriptor descr = descriptors::no_operation,
@@ -525,8 +525,6 @@ namespace grb {
525525
<< inout << " and op = " << &op << std::endl;
526526
#endif
527527
// static sanity checks
528-
static_assert( !grb::internal::maybe_noop< Operator >::value,
529-
"Operators passed to reduce must never be able to generate no-ops" );
530528
static_assert( !grb::is_object< IOType >::value,
531529
"grb::collectives::allreduce cannot have another ALP object as its scalar "
532530
"type!" );
@@ -596,8 +594,6 @@ namespace grb {
596594
<< &monoid << std::endl;
597595
#endif
598596
// static sanity checks
599-
static_assert( !grb::internal::maybe_noop< Monoid >::value, "Monoids passed to "
600-
"reduce must never be able to generate no-ops" );
601597
static_assert( !grb::is_object< IOType >::value,
602598
"grb::collectives::allreduce cannot have another ALP object as its scalar "
603599
"type!" );

0 commit comments

Comments
 (0)