Table names with embedded space characters are incorrectly escaped.

[jostockley]

In the protected method, worksheet_url in table.rb the CGI.escape method is called to escape special characters in the url. The problem is that this method replaces space characters with a '+' rather than %20. The '+' would be correct for url parameters but is not correct for spaces in the url path.

Possible fixes:

1. Change to CGI.escape(s).gsub('+','%20')
2. Remove it altogether and leave it up to the user to make sure spaces are escaped correctly.

[calebhicks]

Also running into this issue.

[syrnick]

@calebhicks does master work for you?

[calebhicks]

Unfortunately, no. The URL escaping uses the + sign instead of %20 so tables with spaces aren’t correctly pulled. On Thu, Dec 7, 2017 at 6:55 AM, Alexander Sorokin <notifications@github.com> wrote: @calebhicks [https://github.com/calebhicks] does master work for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [#23 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AA3gBLmQl82kn689tKueBtjMkS14cw2jks5s9-5jgaJpZM4MzxYX] .

[syrnick]

Strange. master should be using this https://github.com/Airtable/airtable-ruby/blob/master/lib/airtable/table.rb#L116 and that handles spaces correctly

irb(main):014:0> url_encode('//asasdf asdf%a?s & d/')
=> "%2F%2Fasasdf%20asdf%25a%3Fs%20%26%20d%2F"