Skip to content

fix: resolve code-scanning alerts + update deps (minor/patch)#885

Merged
EmersonBraun merged 3 commits into
mainfrom
fix/code-scanning-and-dep-updates
May 22, 2026
Merged

fix: resolve code-scanning alerts + update deps (minor/patch)#885
EmersonBraun merged 3 commits into
mainfrom
fix/code-scanning-and-dep-updates

Conversation

@EmersonBraun
Copy link
Copy Markdown
Collaborator

Summary

Two parts, one commit each.

1. Security — code-scanning alerts (9d3ddbb)

Resolves open GitHub code-scanning alerts:

Rule Files Fix
polynomial-redos generative-ui.ts removed ambiguous \s* in fence regex
bad-tag-filter / double-escaping / incomplete-multi-character-sanitization fetch-url.ts, web-search.ts strip HTML in a loop until stable; decode & last
incomplete-sanitization reporters.ts, flow.ts, redis.test.ts, check-for-agents-coverage.mjs hardened table cells, Mermaid labels, key patterns, regex escaping
incomplete-url-substring-sanitization openai.ts exact host match via URL
stack-trace-exposure ask-docs/route.ts generic error to client, log server-side
file-system-race config.ts, docs-new.mjs atomic create with wx flag
insecure-temporary-file config.test.ts, scaffold.test.ts mkdtemp for test dirs
unused-local-variable 15 files removed dead imports/vars

The two js/file-access-to-http alerts (embedders.ts, check-links.mjs) are
intentional outbound requests — the embedder and the link-checker exist to
make them. Documented inline; alerts dismissed as won't-fix.

2. Dependency updates — minor/patch (e0152e7)

pnpm -r update within existing semver ranges. @types/node, vitest,
@vitest/coverage-v8, @types/react, vite, fumadocs-core/ui, motion,
svelte, @angular/core, @cloudflare/workers-types. marked 15→18 skipped (major).

Test plan

  • pnpm build — 36/36 ✅
  • pnpm test — 37/37 ✅

Note: 2 pre-existing failures in tests/interop.test.ts (built-in tool
discovery) are unrelated to this branch — present on main.

Address GitHub code-scanning alerts across the monorepo:

- polynomial-redos: remove ambiguous `\s*` in the fenced-block regex
  (generative-ui.ts)
- bad-tag-filter / double-escaping / incomplete-multi-character-
  sanitization: rewrite HTML stripping to loop until stable and decode
  `&` last (fetch-url.ts, web-search.ts)
- incomplete-sanitization: harden markdown-table cells, Mermaid labels,
  redis key-pattern and regex escaping (reporters.ts, flow.ts,
  redis.test.ts, check-for-agents-coverage.mjs)
- incomplete-url-substring-sanitization: match the OpenAI host exactly
  via URL parsing instead of a prefix check (openai.ts)
- stack-trace-exposure: return a generic error, log details server-side
  (ask-docs/route.ts)
- file-system-race: use the `wx` open flag for atomic create
  (config.ts, docs-new.mjs)
- insecure-temporary-file: create test dirs with mkdtemp
  (config.test.ts, scaffold.test.ts)
- unused-local-variable: drop dead imports and variables

The two js/file-access-to-http alerts (embedders.ts, check-links.mjs)
are intentional outbound requests; documented inline and dismissed.
Run `pnpm -r update` to pull minor/patch updates within existing
semver ranges across all packages:

- @types/node 25.9.0 -> 25.9.1
- vitest / @vitest/coverage-v8 4.1.6 -> 4.1.7
- @types/react 19.2.14 -> 19.2.15
- vite 8.0.13 -> 8.0.14
- fumadocs-core / fumadocs-ui 16.8.12 -> 16.9.0
- motion 12.39.0 -> 12.40.0
- svelte 5.55.8 -> 5.55.9
- @angular/core 21.2.13 -> 21.2.14
- @cloudflare/workers-types 4.20260519.1 -> 4.20260521.1

marked (15 -> 18) is a major bump and was intentionally skipped.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
agentskit-doc Ignored Ignored Preview May 22, 2026 12:29am

Comment thread packages/eval/src/ci/reporters.ts Fixed
Comment thread packages/tools/src/fetch-url.ts Fixed
- resync pnpm-lock.yaml so `next` importer specifier matches the
  overridden `>=16.2.6` (CI frozen-lockfile install was failing)
- stripHtml: drop unterminated `<!--` comments and loop comment +
  tag removal until stable (CodeQL incomplete-multi-character-
  sanitization, alert 62)
- reporters.ts: escape backslashes before pipes in Markdown table
  cells (CodeQL incomplete string escaping, alert 63)
- add changeset for the code-scanning fixes + dependency sweep
@EmersonBraun EmersonBraun merged commit 8f0999a into main May 22, 2026
14 checks passed
@EmersonBraun EmersonBraun deleted the fix/code-scanning-and-dep-updates branch May 22, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants