feat(openapi): updated spec file, corrections & improvement following new spec

- spec update according to [anonymized](#1 (comment)) input from @WolfwithSword.
- added comments (still needs proper XML formatting) to the spec and marked required fields as such
- added more convenience methods, since the required fields are mostly in query params and required query params can still be nullable according to spec
- naming (affiliate events -> traffic events)
- resilience policy are now configurable
- added static methods for parsing UTC DateTimeOffset and Monetary Values consistently
- general cleanup of type naming

Author: Agash

GoAffPro.Client.slnx

@@ -5,6 +5,7 @@
     <File Path="Directory.Packages.props" />
     <File Path="global.json" />
     <File Path="NuGet.config" />
+    <File Path="openapi/goaffpro-canonical.yaml" />
   </Folder>
   <Folder Name="/src/">
     <Project Path="src/GoAffPro.Client.Generated/GoAffPro.Client.Generated.csproj" />

examples/GoAffPro.Client.Example/GoAffPro.Client.Example.csproj

@@ -1,11 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <EnableNativeAotCompilation>true</EnableNativeAotCompilation>
+    <PublishSingleFile>true</PublishSingleFile>
+    <RuntimeIdentifier>win-x64</RuntimeIdentifier>
+    <InvariantGlobalization>true</InvariantGlobalization>
   </PropertyGroup>
 
   <ItemGroup>
@@ -22,4 +24,7 @@
     <PackageReference Include="Spectre.Console" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Folder Include="Properties\" />
+  </ItemGroup>
 </Project>

examples/GoAffPro.Client.Example/Program.cs

@@ -242,8 +242,8 @@ static async Task CallEndpointAsync(GoAffProClient client)
         "GET /user/stats/aggregate" => await client.Api.User.Stats.Aggregate.GetAsync(config =>
         {
             config.QueryParameters.SiteIds = siteIds;
-            config.QueryParameters.StartTime = AskOptional("start_time (ISO8601, optional)") ?? startTime;
-            config.QueryParameters.EndTime = AskOptional("end_time (ISO8601, optional)") ?? endTime;
+            config.QueryParameters.StartTime = DateTimeOffset.Parse(AskOptional("start_time (ISO8601, optional)") ?? startTime, CultureInfo.InvariantCulture);
+            config.QueryParameters.EndTime = DateTimeOffset.Parse(AskOptional("end_time (ISO8601, optional)") ?? endTime, CultureInfo.InvariantCulture);
             config.QueryParameters.FieldsAsGetFieldsQueryParameterType =
             [
                 AggregateField.Total_sales,
@@ -258,24 +258,24 @@ static async Task CallEndpointAsync(GoAffProClient client)
             config.QueryParameters.Limit = limit;
             config.QueryParameters.Offset = offset;
             config.QueryParameters.SiteIds = siteIds;
-            config.QueryParameters.CreatedAtMin = AskOptional("created_at_min (ISO8601, optional)") ?? startTime;
-            config.QueryParameters.CreatedAtMax = AskOptional("created_at_max (ISO8601, optional)") ?? endTime;
+            config.QueryParameters.CreatedAtMin = DateTimeOffset.Parse(AskOptional("created_at_min (ISO8601, optional)") ?? startTime, CultureInfo.InvariantCulture);
+            config.QueryParameters.CreatedAtMax = DateTimeOffset.Parse(AskOptional("created_at_max (ISO8601, optional)") ?? endTime, CultureInfo.InvariantCulture);
         }).ConfigureAwait(false),
         "GET /user/feed/traffic" => await client.Api.User.Feed.Traffic.GetAsync(config =>
         {
             config.QueryParameters.Limit = limit;
             config.QueryParameters.Offset = offset;
             config.QueryParameters.SiteIds = siteIds;
-            config.QueryParameters.StartTime = AskOptional("start_time (ISO8601, optional)") ?? startTime;
-            config.QueryParameters.EndTime = AskOptional("end_time (ISO8601, optional)") ?? endTime;
+            config.QueryParameters.StartTime = DateTimeOffset.Parse(AskOptional("start_time (ISO8601, optional)") ?? startTime, CultureInfo.InvariantCulture);
+            config.QueryParameters.EndTime = DateTimeOffset.Parse(AskOptional("end_time (ISO8601, optional)") ?? endTime, CultureInfo.InvariantCulture);
         }).ConfigureAwait(false),
         "GET /user/feed/payouts" => await client.Api.User.Feed.Payouts.GetAsync(config =>
         {
             config.QueryParameters.Limit = limit;
             config.QueryParameters.Offset = offset;
             config.QueryParameters.SiteIds = siteIds;
-            config.QueryParameters.StartTime = AskOptional("start_time (ISO8601, optional)") ?? startTime;
-            config.QueryParameters.EndTime = AskOptional("end_time (ISO8601, optional)") ?? endTime;
+            config.QueryParameters.StartTime = DateTimeOffset.Parse(AskOptional("start_time (ISO8601, optional)") ?? startTime, CultureInfo.InvariantCulture);
+            config.QueryParameters.EndTime = DateTimeOffset.Parse(AskOptional("end_time (ISO8601, optional)") ?? endTime, CultureInfo.InvariantCulture);
         }).ConfigureAwait(false),
         "GET /user/feed/products" => await client.Api.User.Feed.Products.GetAsync(config =>
         {
@@ -287,8 +287,8 @@ static async Task CallEndpointAsync(GoAffProClient client)
             config.QueryParameters.Limit = limit;
             config.QueryParameters.Offset = offset;
             config.QueryParameters.SiteIds = siteIds;
-            config.QueryParameters.StartTime = AskOptional("start_time (ISO8601, optional)") ?? startTime;
-            config.QueryParameters.EndTime = AskOptional("end_time (ISO8601, optional)") ?? endTime;
+            config.QueryParameters.StartTime = DateTimeOffset.Parse(AskOptional("start_time (ISO8601, optional)") ?? startTime, CultureInfo.InvariantCulture);
+            config.QueryParameters.EndTime = DateTimeOffset.Parse(AskOptional("end_time (ISO8601, optional)") ?? endTime, CultureInfo.InvariantCulture);
         }).ConfigureAwait(false),
         "GET /user/feed/transactions" => await client.Api.User.Feed.Transactions.GetAsync(config =>
         {
@@ -474,8 +474,8 @@ public Task StartAsync()
 
         client.OrderDetected += (_, args) =>
             WriteLiveEvent("order", args.Order.Id?.String ?? args.Order.OrderId?.String ?? "<unknown>");
-        client.AffiliateDetected += (_, args) =>
-            WriteLiveEvent("affiliate", args.Affiliate.AffiliateId?.String ?? args.Affiliate.Id?.String ?? args.Affiliate.CustomerId?.String ?? "<unknown>");
+        client.TrafficDetected += (_, args) =>
+            WriteLiveEvent("traffic", args.Traffic.AffiliateId?.String ?? args.Traffic.Id?.String ?? args.Traffic.CustomerId?.String ?? "<unknown>");
         client.PayoutDetected += (_, args) =>
             WriteLiveEvent("payout", args.Payout.Id?.String ?? args.Payout.PayoutId?.String ?? "<unknown>");
 
@@ -572,8 +572,8 @@ public static async Task<ApiSweepReport> RunAllAsync(
         TimeSpan productTimeout,
         CancellationToken cancellationToken)
     {
-        string startTime = DateTimeOffset.UtcNow.AddDays(-1).ToString("o", CultureInfo.InvariantCulture);
-        string endTime = DateTimeOffset.UtcNow.ToString("o", CultureInfo.InvariantCulture);
+        DateTimeOffset startTime = DateTimeOffset.UtcNow.AddDays(-1);
+        DateTimeOffset endTime = DateTimeOffset.UtcNow;
         var results = new List<ApiEndpointResult>();
 
         await RunEndpointAsync(results, "GET /user", () => client.Api.User.GetAsync(cancellationToken: cancellationToken)).ConfigureAwait(false);