-
Notifications
You must be signed in to change notification settings - Fork 144
Generate Transfers API and TransferWebhooks models #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the data models for the Transfers API and Transfer Webhooks. It introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism for handling nullable fields during JSON serialization across a large number of model classes, which is essential for PATCH-like API operations. This is achieved by adding isSet... flags for each property and a getExplicitNulls() method that leverages Jackson's @JsonAnyGetter. The changes are consistent and appear to be auto-generated, which is appropriate for this kind of widespread modification. The overall approach is sound. I've included a few minor suggestions to improve efficiency by pre-sizing HashMap instances in the generated getExplicitNulls() methods, which could be beneficial if these objects are instantiated frequently.
| * Sets whether attributes with null values should be explicitly included in the JSON payload. | ||
| * Default is false. | ||
| */ | ||
| @JsonIgnore private boolean includeNullValues = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easy to not add this to webhooks actually ? They don't make a lot of sense since the SDK would be in the receiving end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. The advantage now is consistent generation across all models, but we can customise it to target only the API models. It introduces a custom behavior, but this code is typically easy to understand and we can add tests to check the generated code.
PR to generate the Transfers API and TransferWebhooks models.
Transfers API
UltimatePartyIdentificationaddfundingInstrumentattributeBankAccountV3addstoredPaymentMethodIdattributeTransferandTransferDataadd add enumReasonEnum.SCHEMEADVICETransfer Webhooks
BankAccountV3addstoredPaymentMethodIdattributeTransfer,TransferDataandTransferEventadd add enumReasonEnum.SCHEMEADVICEAll models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603)