pyrofishingpro support

[dinobossytnew]

Describe the bug

I try to cast 1 rod with pyrofishingpro and when I cast and fish it is not taking the fish exp.

How to reproduce

So install the 2 plugins and get the job done.###

Screenshots / Videos

I did not have time to record the video

Server Log

https://mcpaste.io/1ab148e58c75100e

[KPGTB]

Hey! I'm sorry, but it seems that this isn't a bug. PyroFishingPro uses own system of catching fish which replaces default minecraft system used by our plugin. I changed the label of this issue to feature request and maybe in the future we will add official support for this plugin (using external action). This plugin has small API only for people who bought this plugin, so it's quite problematic for us to implement this now.

[Saros-6585]

Hey! I'm sorry, but it seems that this isn't a bug. PyroFishingPro uses own system of catching fish which replaces default minecraft system used by our plugin. I changed the label of this issue to feature request and maybe in the future we will add official support for this plugin (using external action). This plugin has small API only for people who bought this plugin, so it's quite problematic for us to implement this now.

Is there any progress with the support for PyroFishingPro?

[Saros-6585]

@KPGTB I know it's not easy to keep PyroFishingPro and the default minecraft fishing system at the same time, but PFP's fishing event seems to be detected in PlayerFishEvent too. so how about managing PyroFishCatchEvent separately to keep the item information that was caught and processing that information separately within PlayerFishEvent to add support? one of the open-source plugin(Jobs Reborn), supports PFP compatibility in this way.

or it's cool too that if people enable 'Using-PyroFishingPro(example)' in config, register PyroFishCatchEvent Listener instead of registering it with PlayerFishEvent Listener. - I don't think people want to keep minecraft default fishing system at the same time even though they use PFP, so I think this method would be practically possible as well.

[KPGTB]

So, maybe something has been changed, but the last time when I checked this, the API was available only for those who bought this plugin 😢

[Saros-6585]

I heard from Pyro that OpenAPI work is in progress, but it doesn't seem to be close. Is there no plan for add support before OpenAPI is released?

[KPGTB]

We won't add support for this plugin until API isn't free