fix(nanodump): remove -static flag for macOS compatibility#144
Open
ROCKLEE-1998 wants to merge 1 commit into
Open
fix(nanodump): remove -static flag for macOS compatibility#144ROCKLEE-1998 wants to merge 1 commit into
ROCKLEE-1998 wants to merge 1 commit into
Conversation
- Remove -static flag from bin2c compilation (line 26) - Remove -static flag from restore_signature compilation (line 78) - Remove incorrect mingw strip command for native binary (line 79) macOS does not support static linking of system libraries, which caused 'library crt0.o not found' linker errors. This fix allows the project to build successfully on macOS while maintaining compatibility with Linux. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes compilation error on macOS by removing
-staticlinker flag from nanodump Makefile.Problem
macOS does not support static linking of system libraries, which caused the following linker error:
Changes
-staticflag frombin2ccompilation (line 26)-staticflag fromrestore_signaturecompilation (line 78)Testing
Successfully compiled all 131 BOF modules on macOS 14.5 with:
Compatibility
This change maintains compatibility with Linux builds while enabling macOS compilation.