Fix jump psexec random service name/description bug#135
Open
CodeStuffBreakThings wants to merge 1 commit into
Open
Fix jump psexec random service name/description bug#135CodeStuffBreakThings wants to merge 1 commit into
CodeStuffBreakThings wants to merge 1 commit into
Conversation
Author
|
Also not sure why the commit shows me removing/re-adding line 517. That might have been my text editor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the operator does not specify a service name and/or service description, the
jump psexecBOF is supposed to generate and use a random service name and/or service description (technically, display name).Currently, the
lateral.axsscript compares the svc_name and svc_description length, not the value, to the "random" string, so the condition is never true and the values never get randomized. This results in the service name and service display name being literally "random" every time thatjump psexecis used without specifying the service name which generates a 1078 error the next time the BOF is ran since the "random" service name will already exist.This pull request is for updating the if statements to compare the values of svc_name and svc_description, rather than the lengths.