From ea433bbdc422dc26cbae6b738ef5e56dd613dc03 Mon Sep 17 00:00:00 2001 From: "stephen@baydush.net" Date: Wed, 21 Mar 2018 16:23:01 -0400 Subject: [PATCH 1/5] added ability to show rotten and fresh icons --- MMM-RottenTomatoes.js | 37 +++++++++++++++++++++++++++++++++---- icons/fresh-16.png | Bin 0 -> 1631 bytes icons/splat-16.png | Bin 0 -> 1720 bytes 3 files changed, 33 insertions(+), 4 deletions(-) create mode 100644 icons/fresh-16.png create mode 100644 icons/splat-16.png diff --git a/MMM-RottenTomatoes.js b/MMM-RottenTomatoes.js index 0700564..5246b5a 100644 --- a/MMM-RottenTomatoes.js +++ b/MMM-RottenTomatoes.js @@ -18,13 +18,14 @@ Module.register("MMM-RottenTomatoes", { // optional showHeader: true, showOpeningThisWeek: true, - showBoxOffice: true, + showBoxOffice: false, showComingSoon: true, limitOpeningThisWeek: 3, limitBoxOffice: 3, limitComingSoon: 3, boxOfficeAfter: true, mergeOpeningAndComingSoon: true, + showTomatoImages: true, }, // the start function start: function() { @@ -103,7 +104,7 @@ Module.register("MMM-RottenTomatoes", { return wrapper; } var titleSize = 'xsmall'; - var movieSize = 'xsmall'; + var movieSize = 'small'; var wrapper = document.createElement("table"); // do opening this week var allOTWandCSRows = [ ]; @@ -122,8 +123,22 @@ Module.register("MMM-RottenTomatoes", { (cIndex < otwData.length) && (cIndex < this.config.limitOpeningThisWeek); cIndex++) { var cOTW = otwData[cIndex]; - var otwRowTR = document.createElement("tr"); + var otwRowTR = document.createElement("tr"); + + // This section shows the either rotten or fresh rating based on percentage otwRowTR.className = movieSize; + if (this.config.showTomatoImages == true) { + var otwRowTomato = document.createElement("td"); + var otwmoviepercent = parseFloat(this.cleanScore(cOTW.meter)) / 100.0; + if(otwmoviepercent < .75) + { + otwRowTomato.innerHTML = '' + "  "; + }else if (otwmoviepercent >= .75) { + otwRowTomato.innerHTML = '' + "  "; + } + otwRowTR.appendChild(otwRowTomato); + } + var otwRowMeter = document.createElement("td"); otwRowMeter.innerHTML = this.cleanScore(cOTW.meter) + "  "; otwRowTR.appendChild(otwRowMeter); @@ -144,7 +159,7 @@ Module.register("MMM-RottenTomatoes", { csTitleTR.className = titleSize; var csTitleTD = document.createElement("td"); csTitleTD.innerHTML = "Coming Soon"; - csTitleTD.colSpan = "3"; + csTitleTD.colSpan = "4"; csTitleTR.appendChild(csTitleTD); if (!this.config.mergeOpeningAndComingSoon) allOTWandCSRows.push(csTitleTR); @@ -154,6 +169,20 @@ Module.register("MMM-RottenTomatoes", { var ccs = csData[cIndex]; var csRowTR = document.createElement("tr"); csRowTR.className = movieSize; + + // This section shows the either rotten or fresh rating based on percentage + if (this.config.showTomatoImages == true) { + var csRowTomato = document.createElement("td"); + var moviepercent = parseFloat(this.cleanScore(ccs.meter)) / 100.0; + if(moviepercent < .75) + { + csRowTomato.innerHTML = '' + "  "; + }else if (moviepercent >= .75) { + csRowTomato.innerHTML = '' + "  "; + } + csRowTR.appendChild(csRowTomato); + } + var csRowMeter = document.createElement("td"); csRowMeter.innerHTML = this.cleanScore(ccs.meter) + "  "; csRowTR.appendChild(csRowMeter); diff --git a/icons/fresh-16.png b/icons/fresh-16.png new file mode 100644 index 0000000000000000000000000000000000000000..da35bf99d6027d5181db9b25dc7766ca4501aa84 GIT binary patch literal 1631 zcmeAS@N?(olHy`uVBq!ia0vp^3LwnE1|*BCs=fdz$r9IylHmNblJdl&R0hYC{G?O` z&)mfH)S%SFl*+=BsWuD@%*vS|5hW46K32*3xq68pHF_1f1wh>l3^w)^1&PVosU-?Y zsp*+{wo31J?^jaDOtDo8H}y5}EpSfF$n>ZxN)4{^3rViZPPR-@vbR&PsjvbXkegbP zs8ErclUHn2VXFi-*9yo63F|8hqhMrUXs&Nys&8PXYhY+)U}0rsr~m~@K--E^(yW49+@N*=dA3R!B_#z``ugSN z<$C4Ddih1^`i7R4mih)p`bI{&Koz>hm3bwJ6}oxF$}kgLQj3#|G7CyF^YauyCMG83 zmzLNn0bL65LT&-v*t}wBFaZNhzap_f-%!s0||=-;_T+=Y;I`iYVPRlY~bwZXzXU- z=wxbYW(m{llAm0fo0?Yw)0=|O>w;4+C@tg`0Bv?jEy^rQO>ryA&s6~X*(wvaTO4tk z2i2Q`+bvEw_38s1qYsK%q?m>Y0h14i2~W2`4m{n@>)!)P)2_719TC@9%RW_ZPso|05g`JO{!RKezni!g ziR)i&st}Oh!ph&3;97Grh-q6u?t+y`QQ2~57w?|E=KsV<&X*~hJujbSx8K(y`|bby z{Is&PiqO!VMQtnoKB%-ySN>OKn^`U;!)kqH^S&=Jty}xL*>3MXz?;C@et>&Mk+M9y z=>y&!?8z&gdOyq(-ph4CYm4$-_WXm&1?(JO3K?XY8^cvsGq6loj%8Szp!=a&;|6b8 zTF2=GYYuT^kuzKldpK8$TlAK+Iq|5jxM+8wvun@ka7M@UqIoRK4;-(Vd!oW$^ahik zfbeRoSJq2&%?@7BI??5SfLrgqui`cj3TS1$-G_@nD#{_@O!`L~Lx1vm6={91D;O-qAy_n&JM4hwm6#@w=; z8WA$Fn%Ae*?wm<%;Zz;{WwNb_9a>Nt%0@fW|=gzEZxD)ZzL2CKa zS?3k*_eOcwCmB`qZJDXycZjJkquz*D#-LC*Crz?ocE*9DMgiH28n5awFY07-nbtU^ zlTBq>V?!s~A06g+ACnJ_sSlQRvd!DbW25&iBsig`@m(a_21kL9(P|PqSahGMs1(Zn zcoz7_^2H_F2?^f!9Mn&466&73IF`Fg{-W)K1qaKQ#3pQMd9?muov)4Y40bLP8MmxO z&;Rdq5sF#(=;0zgH3^|2{vAGXK@9~mHZ0c_Y*v-)nAaFLO*Hjre|hwXtN9eKUlu;? vJvC=eyj>xEC{Wp4dEcGw$&K2@e?$`)_IdH7dM$M@1r_<8u6{1-oD!M<6pCX( literal 0 HcmV?d00001 diff --git a/icons/splat-16.png b/icons/splat-16.png new file mode 100644 index 0000000000000000000000000000000000000000..0595d495b05d9d9747057efbdad801484dc1823a GIT binary patch literal 1720 zcmeAS@N?(olHy`uVBq!ia0vp^3LwnE1|*BCs=fdz$r9IylHmNblJdl&R0hYC{G?O` z&)mfH)S%SFl*+=BsWuD@%*vS|5hW46K32*3xq68pHF_1f1wh>l3^w)^1&PVosU-?Y zsp*+{wo31J?^jaDOtDo8H}y5}EpSfF$n>ZxN)4{^3rViZPPR-@vbR&PsjvbXkegbP zs8ErclUHn2VXFi-*9yo63F|8hqhMrUXs&Nys&8PXYhY+)U}0rsr~m~@K--E^(yW49+@N*=dA3R!B_#z``ugSN z<$C4Ddih1^`i7R4mih)p`bI{&Koz>hm3bwJ6}oxF$}kgLQj3#|G7CyF^YauyCMG83 zmzLNn0bL65LT&-v*t}wBFaZNhzap_f-%!s0x@$`C@tg`0Bv?jEy^rQO>ryA&s6~X*(wvaTP$&! z2i2Q`+bxbb_38s1qYsK%q?m>Y0h14i2~W2`4m{q>2kaYjuE@YORJ=)qWMug&aaG+)Z9hN{c!iUU;(9e(;uG z<$vq&yb$@S3ArwfH*R++9XYl1g3qE$Z_Ev(m*3vI`}w;p-aj*Um!GrzY+rot%pKm6 z(o)sG{+u^>y!b@Fy5}+;Rp72+G+nS~@q%B@{Xz$RI$Ys3IC}Jt&=bc+rg2P;-G)!) z&bc0InB=0A;Jm=1tu{)DWs>f(9-kAAD^}=h@tPEe%>C%{Ad=^IF#mDO2aDovsC}4s zfA%BA4U#qeN&Gu4&b!@Zpg-4+okg==1>v6xlxNb&SJDkV(#(PEXfOyQg2v3J#ruSE+~ zBrkh-L4$dDb5L)9%dOt@m6NU))Hu|yXMUV)k#C}(*Kkt(!s& z;ofvjNU8Fuih)e6bkDnIZt5$4bJVb{-SydP&h`ISdrWl88cnOdb)Hh(Af2weZ)aoGtGJ( zRP$*{NOzo^ri--We2aIDF$XR`kgGV6c5j!^fy!0OZuH3g`}2FnO|{H=F(=uH$~V6A z&*}C!8pF2AA$G}i4;Ga>%}GAfX4NyEVVfzJob|fa_Gi}kiKMf-v;zh6?~l+)YC*=;K(rLNNR>*BKP zwq$`7pF`7bK27cHx*mJ*W61M%O)oQxQ_1H}EjS-?sw3%i>B=QV?P`s4A8b`#eQHDa z&t3=9tk(9OjjWq>{v~rAstRB8Z^n#G@twPOG)yOuQsb^l?e!#p| lccJdVGMjmyet0)9GFY4b%s#pF`4muH;_2$=vd$@?2>=e5l0N_d literal 0 HcmV?d00001 From 17dd13924f2a8f20f5e9738551678e6077365af4 Mon Sep 17 00:00:00 2001 From: sbaydush Date: Wed, 21 Mar 2018 16:25:08 -0400 Subject: [PATCH 2/5] Update README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index 58747ec..59e70c7 100644 --- a/README.md +++ b/README.md @@ -99,6 +99,14 @@ The following properties can be configured:
Default value: true
This value is OPTIONAL + + + showTomatoImages + Boolean value, Whether or not to display rotten tomatoes fresh/rotten images next to the percentages.
+
Example: false +
Default value: true +
This value is OPTIONAL + From 27488b4a1b0c5e4bc9b8eb0304e09f0ee826ae96 Mon Sep 17 00:00:00 2001 From: "stephen@baydush.net" Date: Wed, 21 Mar 2018 16:28:27 -0400 Subject: [PATCH 3/5] undid default change --- MMM-RottenTomatoes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MMM-RottenTomatoes.js b/MMM-RottenTomatoes.js index 5246b5a..cce3c3e 100644 --- a/MMM-RottenTomatoes.js +++ b/MMM-RottenTomatoes.js @@ -18,7 +18,7 @@ Module.register("MMM-RottenTomatoes", { // optional showHeader: true, showOpeningThisWeek: true, - showBoxOffice: false, + showBoxOffice: true, showComingSoon: true, limitOpeningThisWeek: 3, limitBoxOffice: 3, From 260041d226f1a53ec2d97c58fed0c4c31e64af8d Mon Sep 17 00:00:00 2001 From: "stephen@baydush.net" Date: Wed, 21 Mar 2018 16:30:11 -0400 Subject: [PATCH 4/5] undid unneeded change --- MMM-RottenTomatoes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MMM-RottenTomatoes.js b/MMM-RottenTomatoes.js index cce3c3e..460989c 100644 --- a/MMM-RottenTomatoes.js +++ b/MMM-RottenTomatoes.js @@ -159,7 +159,7 @@ Module.register("MMM-RottenTomatoes", { csTitleTR.className = titleSize; var csTitleTD = document.createElement("td"); csTitleTD.innerHTML = "Coming Soon"; - csTitleTD.colSpan = "4"; + csTitleTD.colSpan = "3"; csTitleTR.appendChild(csTitleTD); if (!this.config.mergeOpeningAndComingSoon) allOTWandCSRows.push(csTitleTR); From 1bdff5a3b9453baa85f169e432eb2ed126dc9118 Mon Sep 17 00:00:00 2001 From: sbaydush Date: Sun, 13 Jan 2019 17:23:47 -0500 Subject: [PATCH 5/5] Update MMM-RottenTomatoes.js --- MMM-RottenTomatoes.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MMM-RottenTomatoes.js b/MMM-RottenTomatoes.js index 460989c..53d91e9 100644 --- a/MMM-RottenTomatoes.js +++ b/MMM-RottenTomatoes.js @@ -174,10 +174,10 @@ Module.register("MMM-RottenTomatoes", { if (this.config.showTomatoImages == true) { var csRowTomato = document.createElement("td"); var moviepercent = parseFloat(this.cleanScore(ccs.meter)) / 100.0; - if(moviepercent < .75) + if(moviepercent < .60) { csRowTomato.innerHTML = '' + "  "; - }else if (moviepercent >= .75) { + }else if (moviepercent >= .60) { csRowTomato.innerHTML = '' + "  "; } csRowTR.appendChild(csRowTomato);