U617-025: fix completionItem/resolve requests for runtime symbols

Author: AnthonyLeonardoGracio

source/ada/lsp-ada_contexts.adb

@@ -781,9 +781,10 @@ package body LSP.Ada_Contexts is
    -----------------
 
    function Get_Node_At
-     (Self     : Context;
-      Document : LSP.Ada_Documents.Document_Access;
-      Position : LSP.Messages.TextDocumentPositionParams'Class)
+     (Self         : Context;
+      Document     : LSP.Ada_Documents.Document_Access;
+      Position     : LSP.Messages.TextDocumentPositionParams'Class;
+      Project_Only : Boolean := True)
       return Libadalang.Analysis.Ada_Node
    is
       use type Libadalang.Analysis.Ada_Node;
@@ -801,12 +802,13 @@ package body LSP.Ada_Contexts is
       --  We're about to get a node from an analysis unit. Either the document
       --  is open for it, in which case we read the document, or the
       --  document is not open for it. In this case, resolve this only
-      --  if the file belongs to the project: we don't want to pollute the
-      --  LAL context with units that are not in the project.
+      --  if the file belongs to the project (unless if Project_Only is False):
+      --  we don't want to pollute the LAL context with units that are not in
+      --  the project.
 
       if Document /= null then
          return Document.Get_Node_At (Self, Position.position);
-      elsif Self.Is_Part_Of_Project (File) then
+      elsif not Project_Only or else Self.Is_Part_Of_Project (File) then
          Unit := Self.LAL_Context.Get_From_File
            (Name,
             Charset => Self.Get_Charset);

source/ada/lsp-ada_contexts.ads

@@ -83,13 +83,15 @@ package LSP.Ada_Contexts is
       return Ada.Strings.UTF_Encoding.UTF_8_String;
 
    function Get_Node_At
-     (Self     : Context;
-      Document : LSP.Ada_Documents.Document_Access;
-      Position : LSP.Messages.TextDocumentPositionParams'Class)
+     (Self         : Context;
+      Document     : LSP.Ada_Documents.Document_Access;
+      Position     : LSP.Messages.TextDocumentPositionParams'Class;
+      Project_Only : Boolean := True)
       return Libadalang.Analysis.Ada_Node;
    --  Return the node at the given location.
    --  If Document is not null, get the location from the document, otherwise
-   --  get it from the file.
+   --  get it from the file if it belongs to the context's project when
+   --  Project_Only is True.
 
    procedure Format
      (Self     : in out Context;

source/ada/lsp-ada_documents.ads

@@ -148,7 +148,7 @@ package LSP.Ada_Documents is
       Limit       : Ada.Containers.Count_Type;
       Only_Public : Boolean;
       Canceled    : access function return Boolean;
-      Result  : in out LSP.Ada_Completions.Completion_Maps.Map);
+      Result      : in out LSP.Ada_Completions.Completion_Maps.Map);
    --  See Contexts.Get_Any_Symbol
 
    procedure Get_Folding_Blocks

source/ada/lsp-ada_handlers-invisibles.adb

@@ -138,12 +138,12 @@ package body LSP.Ada_Handlers.Invisibles is
 
                for Doc of Self.Handler.Open_Documents loop
                   Doc.Get_Any_Symbol
-                    (Self.Context.all,
-                     Pattern,
-                     Limit,
-                     True,
-                     Dummy_Canceled'Access,
-                     Names);
+                    (Context     => Self.Context.all,
+                     Pattern     => Pattern,
+                     Limit       => Limit,
+                     Only_Public => True,
+                     Canceled    => Dummy_Canceled'Access,
+                     Result      => Names);
                end loop;
             end;
          end if;

source/ada/lsp-ada_handlers.adb

@@ -3966,9 +3966,10 @@ package body LSP.Ada_Handlers is
 
       C := Self.Contexts.Get_Best_Context (Item.data.Value.uri);
       Node := Get_Node_At
-        (Self     => C.all,
-         Document => null,
-         Position => LSP.Messages.TextDocumentPositionParams'
+        (Self         => C.all,
+         Document     => null,
+         Project_Only => False,
+         Position     => LSP.Messages.TextDocumentPositionParams'
            (textDocument => (uri => Item.data.Value.uri),
             position     => Item.data.Value.span.first));
 

testsuite/ada_lsp/completion.invisible.runtime/test.json

@@ -162,7 +162,7 @@
                }
             }
          },
-         "waitFactor": "40",
+         "waitFactor": "10",
          "wait": [
             {
                 "jsonrpc": "2.0",