Merge branch 'topic/ci' into 'master'

git checkout doesn't support '--' when branch name is specified.

See merge request eng/ide/ada_language_server!1232

Author: godunko

.gitlab-ci.yml

@@ -48,17 +48,17 @@ stages:
   #  On downstream pipeline checkout the necessary branch
   - if [[ "$CI_PIPELINE_SOURCE" == 'pipeline' ]]; then
       if git -C "$CI_PROJECT_DIR" show-ref --quiet -- "$ACI_SOURCE_BRANCH"; then
-        git -C "$CI_PROJECT_DIR" checkout -- "$ACI_SOURCE_BRANCH";
+        git -C "$CI_PROJECT_DIR" checkout "$ACI_SOURCE_BRANCH";
       elif git -C "$CI_PROJECT_DIR" ls-remote --exit-code -- origin "$ACI_SOURCE_BRANCH"; then
         git -C "$CI_PROJECT_DIR" config remote.origin.fetch "+refs/heads/$ACI_SOURCE_BRANCH:refs/remotes/origin/$ACI_SOURCE_BRANCH";
         git -C "$CI_PROJECT_DIR" remote update;
-        git -C "$CI_PROJECT_DIR" checkout -- "$ACI_SOURCE_BRANCH";
+        git -C "$CI_PROJECT_DIR" checkout "$ACI_SOURCE_BRANCH";
       elif git -C "$CI_PROJECT_DIR" show-ref --quiet -- "$ACI_TARGET_BRANCH"; then
-        git -C "$CI_PROJECT_DIR" checkout -- "$ACI_TARGET_BRANCH";
+        git -C "$CI_PROJECT_DIR" checkout "$ACI_TARGET_BRANCH";
       elif git -C "$CI_PROJECT_DIR" ls-remote --exit-code -- origin "$ACI_TARGET_BRANCH"; then
         git -C "$CI_PROJECT_DIR" config remote.origin.fetch "+refs/heads/$ACI_TARGET_BRANCH:refs/remotes/origin/$ACI_TARGET_BRANCH";
         git -C "$CI_PROJECT_DIR" remote update;
-        git -C "$CI_PROJECT_DIR" checkout -- "$ACI_TARGET_BRANCH";
+        git -C "$CI_PROJECT_DIR" checkout "$ACI_TARGET_BRANCH";
       fi
     fi