U224-018 Disable ASCII package as obsolescent

Author: reznikmm

gnat/gnat.adc

@@ -0,0 +1 @@
+pragma Restrictions (No_Obsolescent_Features);

gnat/lsp.gpr

@@ -94,6 +94,7 @@ project LSP is
 
    package Compiler is
       for Default_Switches ("Ada") use Ada_Switches;
+      for Local_Configuration_Pragmas use "gnat.adc";
    end Compiler;
 
    package Naming is

gnat/lsp_server.gpr

@@ -47,6 +47,7 @@ project LSP_Server is
       for Switches ("lsp-ada_driver.adb") use
         LSP.Ada_Switches & ("-gnateDVERSION=""" & VERSION & """");
       for Switches ("s-memory.adb") use ("-g", "-O2", "-gnatpg");
+      for Local_Configuration_Pragmas use "gnat.adc";
    end Compiler;
 
    package Linker is

source/ada/lsp-ada_driver.adb

@@ -17,6 +17,7 @@
 --
 --  This is driver to run LSP server for Ada language.
 
+with Ada.Characters.Latin_1;
 with Ada.Text_IO;
 with Ada.Exceptions;          use Ada.Exceptions;
 with GNAT.Command_Line;       use GNAT.Command_Line;
@@ -106,7 +107,8 @@ procedure LSP.Ada_Driver is
    procedure On_Uncaught_Exception (E : Exception_Occurrence) is
    begin
       Trace (Server_Trace,
-             "EXCEPTION: " & Exception_Name (E) & ASCII.LF &
+             "EXCEPTION: " & Exception_Name (E) &
+               Ada.Characters.Latin_1.LF &
                Symbolic_Traceback (E));
       Handler.Handle_Error;
    end On_Uncaught_Exception;
@@ -118,7 +120,8 @@ procedure LSP.Ada_Driver is
    procedure Die_On_Uncaught (E : Exception_Occurrence) is
    begin
       Trace (Server_Trace,
-             "EXCEPTION: " & Exception_Name (E) & ASCII.LF &
+             "EXCEPTION: " & Exception_Name (E) &
+               Ada.Characters.Latin_1.LF &
                Symbolic_Traceback (E));
       --  An exception occurred while fuzzing: make it fatal.
       GNAT.OS_Lib.OS_Exit (42);

source/ada/lsp-ada_handlers.adb

@@ -2971,19 +2971,19 @@ package body LSP.Ada_Handlers is
               (Is_Error => True)
             do
                declare
-                  Error_Message : VSS.Strings.Virtual_String;
+                  Error_Message : VSS.String_Vectors.Virtual_String_Vector;
 
                begin
                   for Problem of Refs.Problems loop
                      Error_Message.Append
                        (VSS.Strings.Conversions.To_Virtual_String
-                          (Problem.Info & ASCII.LF));
+                          (Problem.Info));
                   end loop;
 
                   Response.error :=
                     (True,
                      (code    => LSP.Errors.InvalidRequest,
-                      message => Error_Message,
+                      message => Error_Message.Join_Lines (VSS.Strings.LF),
                       data    => Empty));
                end;
             end return;

source/ada/lsp-common.adb

@@ -15,6 +15,7 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
+with Ada.Characters.Latin_1;
 with Ada.Exceptions;           use Ada.Exceptions;
 with GNAT.Expect.TTY;
 with GNAT.Traceback.Symbolic;  use GNAT.Traceback.Symbolic;
@@ -110,7 +111,7 @@ package body LSP.Common is
       end if;
 
       Trace.Trace (Exception_Name (E) & ": " & Exception_Message (E)
-                   & ASCII.LF & Symbolic_Traceback (E));
+                   & Ada.Characters.Latin_1.LF & Symbolic_Traceback (E));
    end Log;
 
    ----------------

source/ada/lsp-fuzz_decorators.adb

@@ -18,6 +18,7 @@
 with Ada.Characters.Wide_Latin_1; use Ada.Characters.Wide_Latin_1;
 with Ada.Containers.Hashed_Maps;
 
+with VSS.String_Vectors;
 with VSS.Strings.Conversions;
 with VSS.Unicode;
 
@@ -180,13 +181,22 @@ package body LSP.Fuzz_Decorators is
       if Self.Doc_Provider.Get_Open_Document (Value.textDocument.uri).Text
         /= LSP.Types.To_Virtual_String (Doc_Content)
       then
-         Self.Trace.Trace
-           (VSS.Strings.Conversions.To_UTF_8_String
-              (Self.Doc_Provider.Get_Open_Document
-                   (Value.textDocument.uri).Text) &
-              ASCII.LF & " /= " & ASCII.LF &
-              To_UTF_8_String (Doc_Content));
-         raise Program_Error with "document content inconsistency";
+         declare
+            Vector : VSS.String_Vectors.Virtual_String_Vector;
+         begin
+            Vector.Append
+              (Self.Doc_Provider.Get_Open_Document (Value.textDocument.uri)
+                 .Text);
+
+            Vector.Append (" /= ");
+            Vector.Append (LSP.Types.To_Virtual_String (Doc_Content));
+
+            Self.Trace.Trace
+              (VSS.Strings.Conversions.To_UTF_8_String
+                 (Vector.Join_Lines (VSS.Strings.LF)));
+
+            raise Program_Error with "document content inconsistency";
+         end;
       end if;
    end On_DidChangeTextDocument_Notification;
 

source/memory/lsp-memory_statistics.adb

@@ -15,6 +15,7 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
+with Ada.Characters.Latin_1;
 with Ada.Strings.Unbounded;   use Ada.Strings.Unbounded;
 with GNAT.Regpat;             use GNAT.Regpat;
 with GNAT.Traceback.Symbolic; use GNAT.Traceback.Symbolic;
@@ -34,7 +35,9 @@ package body LSP.Memory_Statistics is
    is
       Buffer           : Unbounded_String := To_Unbounded_String
         ("Dump_Memory_Statistics at 0x" &
-           System.Address_Image (Dump_Memory_Statistics'Address) & ASCII.LF);
+           System.Address_Image (Dump_Memory_Statistics'Address) &
+           Ada.Characters.Latin_1.LF);
+
       Traceback_Regexp : constant Pattern_Matcher :=
                            Compile ("\s0x0+([0-9a-zA-Z]+)");
 
@@ -84,7 +87,7 @@ package body LSP.Memory_Statistics is
 
       procedure Trace_Put_Line (S : String) is
       begin
-         Append (Buffer, S & ASCII.LF);
+         Append (Buffer, S & Ada.Characters.Latin_1.LF);
       end Trace_Put_Line;
 
       procedure Internal is new GNATCOLL.Memory.Redirectable_Dump

source/server/lsp-message_loggers.adb

@@ -15,6 +15,7 @@
 -- of the license.                                                          --
 ------------------------------------------------------------------------------
 
+with Ada.Characters.Latin_1;
 with Ada.Containers;
 with Ada.Strings.Unbounded;
 
@@ -571,8 +572,9 @@ package body LSP.Message_Loggers is
                    Change.a_type'Wide_Image & ";");
       end loop;
 
-      Self.Trace.Trace ("DidChangeWatchedFiles_Notification:"
-                        & ASCII.LF & To_UTF_8_String (Result));
+      Self.Trace.Trace
+        ("DidChangeWatchedFiles_Notification:"
+         & Ada.Characters.Latin_1.LF & To_UTF_8_String (Result));
    end On_DidChangeWatchedFiles_Notification;
 
    -------------------------------------------

source/server/lsp-servers.adb

@@ -45,6 +45,8 @@ package body LSP.Servers is
    New_Line : constant String :=
      (Ada.Characters.Latin_1.CR, Ada.Characters.Latin_1.LF);
 
+   Line_Feed : constant Character := Ada.Characters.Latin_1.LF;
+
    function "+" (Text : Ada.Strings.UTF_Encoding.UTF_8_String)
       return LSP.Types.LSP_String renames
      LSP.Types.To_LSP_String;
@@ -595,7 +597,7 @@ package body LSP.Servers is
          --  Catch-all case: make sure no exception in output writing
          --  can cause an exit of the task loop.
          Self.Server_Trace.Trace
-           ("Exception when reading input:" & ASCII.LF
+           ("Exception when reading input:" & Line_Feed
             & Exception_Name (E) & " - " &  Exception_Message (E));
          Self.Server_Trace.Trace (Symbolic_Traceback (E));
    end Process_One_Message;
@@ -770,7 +772,7 @@ package body LSP.Servers is
       Code       : LSP.Messages.ErrorCodes := LSP.Errors.InternalError)
    is
       Exception_Text : constant String :=
-        Exception_Name (E) & ASCII.LF & Symbolic_Traceback (E);
+        Exception_Name (E) & Line_Feed & Symbolic_Traceback (E);
       Response       : Response_Access :=
         new LSP.Messages.ResponseMessage'
           (Is_Error => True,
@@ -791,8 +793,8 @@ package body LSP.Servers is
 
       --  Log details in the traces
       Self.Server_Trace.Trace
-        ("Exception when processing request:" & ASCII.LF
-         & Trace_Text & ASCII.LF
+        ("Exception when processing request:" & Line_Feed
+         & Trace_Text & Line_Feed
          & Exception_Text);
    end Send_Exception_Response;
 
@@ -1072,8 +1074,8 @@ package body LSP.Servers is
                   --  Catch-all case: make sure no exception in output writing
                   --  can cause an exit of the task loop.
                   Server.Server_Trace.Trace
-                    ("Exception when writing output:" & ASCII.LF
---                     & To_String (Output) & ASCII.LF
+                    ("Exception when writing output:" & Line_Feed
+--                     & To_String (Output) & Line_Feed
                      & Exception_Name (E) & " - " &  Exception_Message (E));
                   Server.Server_Trace.Trace (Symbolic_Traceback (E));
 
@@ -1154,8 +1156,8 @@ package body LSP.Servers is
                when E : others =>
                   --  Always log an exception in the traces
                   Server.Server_Trace.Trace
-                    ("Exception (processing notification):" & ASCII.LF
-                     & Exception_Name (E) & ASCII.LF &
+                    ("Exception (processing notification):" & Line_Feed
+                     & Exception_Name (E) & Line_Feed &
                        Symbolic_Traceback (E));
             end;