fix: tighten TestNoMagicValues exemptions, migrate 3 more sites

Removed blanket 2-10 small int exemption. Now only 0, 1, -1, 2, 3,
and 10 are exempt. Catches 5, 7, and higher magic numbers.

Added constants:
- time.DaysPerWeek (7) — used in relative time formatting
- governance.DriftCheckMinCalls (5) — tool call drift threshold
- format.PreviewLines (5) — status preview line count

Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

internal/audit/magic_values_test.go

@@ -9,16 +9,21 @@ package audit
 import (
 	"go/ast"
 	"go/token"
-	"strconv"
 	"strings"
 	"testing"
 )
 
 // exemptIntLiterals lists integer values that are always acceptable.
+// 0, 1, -1: universal identity/sentinel values.
+// 2, 3: structural constants (split counts, field indices, ternary).
+// 10: decimal radix.
 var exemptIntLiterals = map[string]bool{
 	"0":  true,
 	"1":  true,
 	"-1": true,
+	"2":  true,
+	"3":  true,
+	"10": true,
 }
 
 // strconvRadixBitsize lists numeric literals acceptable as strconv
@@ -97,13 +102,6 @@ func TestNoMagicValues(t *testing.T) {
 					return true
 				}
 
-				// Small integers 2-10 are generally acceptable (arg
-				// counts, field indices, slice bounds, arithmetic).
-				if val, err := strconv.Atoi(lit.Value); err == nil &&
-					val >= 2 && val <= 10 {
-					return true
-				}
-
 				// Octal permissions are handled by TestNoRawPermissions.
 				if strings.HasPrefix(lit.Value, "0o") ||
 					strings.HasPrefix(lit.Value, "0O") {

internal/cli/status/core/out/out.go

@@ -17,6 +17,7 @@ import (
 	"github.com/ActiveMemory/ctx/internal/cli/status/core/preview"
 	"github.com/ActiveMemory/ctx/internal/cli/status/core/sort"
 	"github.com/ActiveMemory/ctx/internal/config/embed/text"
+	cfgFmt "github.com/ActiveMemory/ctx/internal/config/format"
 	cfgTime "github.com/ActiveMemory/ctx/internal/config/time"
 	"github.com/ActiveMemory/ctx/internal/config/token"
 	"github.com/ActiveMemory/ctx/internal/entity"
@@ -56,7 +57,7 @@ func PersistStatusJSON(
 			ModTime: f.ModTime.Format(time.RFC3339),
 		}
 		if verbose && !f.IsEmpty {
-			fs.Preview = preview.Content(string(f.Content), 5)
+			fs.Preview = preview.Content(string(f.Content), cfgFmt.PreviewLines)
 		}
 		output.Files = append(output.Files, fs)
 	}

internal/cli/system/core/archive/backup.go

@@ -123,7 +123,9 @@ func BackupProject(
 
 	// Touch marker file for check-backup-age hook.
 	markerDir := filepath.Join(home, archive.BackupMarkerDir)
-	if mkdirErr := internalIo.SafeMkdirAll(markerDir, cfgFs.PermExec); mkdirErr != nil {
+	if mkdirErr := internalIo.SafeMkdirAll(
+		markerDir, cfgFs.PermExec,
+	); mkdirErr != nil {
 		logWarn.Warn(warn.Mkdir, markerDir, mkdirErr)
 	}
 	markerPath := filepath.Join(markerDir, archive.BackupMarkerFile)

internal/config/format/format.go

@@ -30,4 +30,8 @@ const (
 	// TruncateDescription is the max character width for description
 	// text in skill listings and similar compact displays.
 	TruncateDescription = 70
+
+	// PreviewLines is the number of content lines shown in status
+	// previews and similar compact displays.
+	PreviewLines = 5
 )

internal/config/mcp/governance/governance.go

@@ -20,4 +20,8 @@ const (
 	// PersistNudgeRepeat is how often the persist nudge repeats after
 	// the initial threshold.
 	PersistNudgeRepeat = 8
+
+	// DriftCheckMinCalls is the minimum tool call count before
+	// flagging that drift has never been checked.
+	DriftCheckMinCalls = 5
 )

internal/config/time/hours.go

@@ -11,4 +11,6 @@ const (
 	HoursPerDay = 24
 	// MinutesPerHour is the number of minutes in an hour.
 	MinutesPerHour = 60
+	// DaysPerWeek is the number of days in a week.
+	DaysPerWeek = 7
 )

internal/format/format.go

@@ -46,7 +46,7 @@ func TimeAgo(hours float64, mins int, fallbackDate string) string {
 			return desc.Text(text.DescKeyWriteTimeHourAgo)
 		}
 		return fmt.Sprintf(desc.Text(text.DescKeyWriteTimeHoursAgo), h)
-	case hours < 7*cfgTime.HoursPerDay:
+	case hours < cfgTime.DaysPerWeek*cfgTime.HoursPerDay:
 		days := int(hours / cfgTime.HoursPerDay)
 		if days == 1 {
 			return desc.Text(text.DescKeyWriteTimeDayAgo)

internal/mcp/session/governance.go

@@ -105,8 +105,8 @@ func (ss *State) CheckGovernance(toolName string) string {
 					desc.Text(text.DescKeyGovDriftNotChecked),
 					int(time.Since(ss.lastDriftCheck).Minutes())))
 			}
-		} else if ss.ToolCalls > 5 {
-			// Never checked drift and already 5+ calls in
+		} else if ss.ToolCalls > governance.DriftCheckMinCalls {
+			// Never checked drift and already past threshold
 			warnings = append(warnings,
 				desc.Text(text.DescKeyGovDriftNeverChecked))
 		}