feat: implement missing workspace op and uri issue when opening

Author: bajrangCoder

src/cm/lsp/clientManager.ts

@@ -303,6 +303,8 @@ export class LspClientManager {
 
 		const workspaceOptions = {
 			displayFile: this.options.displayFile,
+			openFile: this.options.openFile,
+			resolveLanguageId: this.options.resolveLanguageId,
 		};
 
 		const clientConfig = { ...(server.clientConfig ?? {}) };
@@ -789,31 +791,32 @@ const defaultManager = new LspClientManager();
 
 export default defaultManager;
 
-const FILE_SCHEME_REQUIRED_SERVERS = new Set(["typescript"]);
-
 function normalizeRootUriForServer(
-	server: LspServerDefinition,
+	_server: LspServerDefinition,
 	rootUri: string | null,
 ): NormalizedRootUri {
 	if (!rootUri || typeof rootUri !== "string") {
 		return { normalizedRootUri: null, originalRootUri: null };
 	}
 	const schemeMatch = /^([a-zA-Z][\w+\-.]*):/.exec(rootUri);
 	const scheme = schemeMatch ? schemeMatch[1].toLowerCase() : null;
+
+	// Already a file:// URI - use as-is
 	if (scheme === "file") {
 		return { normalizedRootUri: rootUri, originalRootUri: rootUri };
 	}
 
+	// Try to convert content:// URIs to file:// URIs
 	if (scheme === "content") {
 		const fileUri = contentUriToFileUri(rootUri);
 		if (fileUri) {
 			return { normalizedRootUri: fileUri, originalRootUri: rootUri };
 		}
-		if (FILE_SCHEME_REQUIRED_SERVERS.has(server.id)) {
-			return { normalizedRootUri: null, originalRootUri: rootUri };
-		}
+		// Can't convert to file:// - server won't work properly
+		return { normalizedRootUri: null, originalRootUri: rootUri };
 	}
 
+	// Unknown scheme - try to use as-is
 	return { normalizedRootUri: rootUri, originalRootUri: rootUri };
 }
 
@@ -839,6 +842,7 @@ function contentUriToFileUri(uri: string): string | null {
 
 		switch (providerId) {
 			case "foxdebug.acode":
+			case "foxdebug.acodefree":
 				normalized = normalized.replace(/:+$/, "");
 				if (!normalized) return null;
 				if (normalized.startsWith("raw:/")) {

src/cm/lsp/types.ts

@@ -188,6 +188,8 @@ export interface ClientManagerOptions {
 	clientExtensions?: Extension | Extension[];
 	resolveRoot?: (context: RootUriContext) => Promise<string | null>;
 	displayFile?: (uri: string) => Promise<EditorView | null>;
+	openFile?: (uri: string) => Promise<EditorView | null>;
+	resolveLanguageId?: (uri: string) => string | null;
 	onClientIdle?: (info: ClientIdleInfo) => void;
 }
 
@@ -236,6 +238,8 @@ export interface WaitOptions {
 
 export interface WorkspaceOptions {
 	displayFile?: (uri: string) => Promise<EditorView | null>;
+	openFile?: (uri: string) => Promise<EditorView | null>;
+	resolveLanguageId?: (uri: string) => string | null;
 }
 
 // ============================================================================

src/cm/lsp/workspace.ts

@@ -1,7 +1,8 @@
 import type { WorkspaceFile } from "@codemirror/lsp-client";
 import { LSPPlugin, Workspace } from "@codemirror/lsp-client";
-import type { Text } from "@codemirror/state";
+import type { Text, TransactionSpec } from "@codemirror/state";
 import type { EditorView } from "@codemirror/view";
+import { getModeForPath } from "cm/modelist";
 import type { WorkspaceFileUpdate, WorkspaceOptions } from "./types";
 
 class AcodeWorkspaceFile implements WorkspaceFile {
@@ -96,6 +97,30 @@ export default class AcodeWorkspace extends Workspace {
 		return next;
 	}
 
+	#resolveLanguageIdForUri(uri: string): string {
+		if (typeof this.options.resolveLanguageId === "function") {
+			const resolved = this.options.resolveLanguageId(uri);
+			if (resolved) return resolved;
+		}
+		try {
+			const mode = getModeForPath(uri);
+			if (mode?.name) {
+				return String(mode.name).toLowerCase();
+			}
+		} catch (_) {}
+		return "plaintext";
+	}
+
+	#getOpenFileCallback(): ((uri: string) => Promise<EditorView | null>) | null {
+		if (typeof this.options.openFile === "function") {
+			return this.options.openFile;
+		}
+		if (typeof this.options.displayFile === "function") {
+			return this.options.displayFile;
+		}
+		return null;
+	}
+
 	syncFiles(): readonly WorkspaceFileUpdate[] {
 		const updates: WorkspaceFileUpdate[] = [];
 		for (const file of this.files) {
@@ -137,12 +162,73 @@ export default class AcodeWorkspace extends Workspace {
 		return this.#getFileEntry(uri);
 	}
 
+	async requestFile(uri: string): Promise<AcodeWorkspaceFile | null> {
+		const existing = this.#getFileEntry(uri);
+		if (existing) return existing;
+
+		const openFileCallback = this.#getOpenFileCallback();
+		if (!openFileCallback) return null;
+
+		try {
+			const view = await openFileCallback(uri);
+			if (!view?.state?.doc) return null;
+			const languageId = this.#resolveLanguageIdForUri(uri);
+			return this.#getOrCreateFile(uri, languageId, view);
+		} catch (error) {
+			console.error(`[LSP:Workspace] Failed to open file: ${uri}`, error);
+			return null;
+		}
+	}
+
+	connected(): void {
+		for (const file of this.files) {
+			this.client.didOpen(file);
+		}
+	}
+
+	updateFile(uri: string, update: TransactionSpec): void {
+		const file = this.#getFileEntry(uri);
+
+		if (file) {
+			const view = file.getView();
+			if (view) {
+				view.dispatch(update);
+				return;
+			}
+		}
+
+		// File is not open - try to open it and apply the update
+		this.#applyUpdateToClosedFile(uri, update).catch((error) => {
+			console.warn(`[LSP:Workspace] Failed to apply update: ${uri}`, error);
+		});
+	}
+
+	async #applyUpdateToClosedFile(
+		uri: string,
+		update: TransactionSpec,
+	): Promise<void> {
+		const openFileCallback = this.#getOpenFileCallback();
+		if (!openFileCallback) return;
+
+		try {
+			const file = await this.requestFile(uri);
+			if (!file) return;
+
+			const view = file.getView();
+			if (view) {
+				view.dispatch(update);
+			}
+		} catch (error) {
+			console.error(`[LSP:Workspace] Failed to apply update: ${uri}`, error);
+		}
+	}
+
 	async displayFile(uri: string): Promise<EditorView | null> {
 		if (typeof this.options.displayFile === "function") {
 			try {
 				return await this.options.displayFile(uri);
 			} catch (error) {
-				console.error("Failed to display file via workspace", error);
+				console.error("[LSP:Workspace] Failed to display file", error);
 			}
 		}
 		return null;

src/lib/editorManager.js

@@ -1155,23 +1155,54 @@ async function EditorManager($header, $body) {
 		},
 		displayFile: async (targetUri) => {
 			if (!targetUri) return null;
-			const existing = manager.getFile(targetUri, "uri");
+			// Decode URI components (e.g., %40 -> @) since LSP returns encoded URIs
+			const decodedUri = decodeURIComponent(targetUri);
+			const existing = manager.getFile(decodedUri, "uri");
 			if (existing?.type === "editor") {
 				existing.makeActive();
 				return editor;
 			}
 			try {
-				await openFile(targetUri, { render: true });
-				const opened = manager.getFile(targetUri, "uri");
+				await openFile(decodedUri, { render: true });
+				const opened = manager.getFile(decodedUri, "uri");
 				if (opened?.type === "editor") {
 					opened.makeActive();
 					return editor;
 				}
 			} catch (error) {
-				console.error("Failed to open file for LSP navigation", error);
+				console.error("[LSP] Failed to open file", decodedUri, error);
 			}
 			return null;
 		},
+		openFile: async (targetUri) => {
+			if (!targetUri) return null;
+			// Decode URI components (e.g., %40 -> @)
+			const decodedUri = decodeURIComponent(targetUri);
+			const existing = manager.getFile(decodedUri, "uri");
+			if (existing?.type === "editor") {
+				existing.makeActive();
+				return editor;
+			}
+			try {
+				await openFile(decodedUri, { render: true });
+				const opened = manager.getFile(decodedUri, "uri");
+				if (opened?.type === "editor") {
+					opened.makeActive();
+					return editor;
+				}
+			} catch (error) {
+				console.error("[LSP] Failed to open file", decodedUri, error);
+			}
+			return null;
+		},
+		resolveLanguageId: (uri) => {
+			if (!uri) return "plaintext";
+			try {
+				const mode = getModeForPath(uri);
+				if (mode?.name) return String(mode.name).toLowerCase();
+			} catch (_) {}
+			return "plaintext";
+		},
 		clientExtensions: [diagnosticsClientExt],
 		diagnosticsUiExtension: buildDiagnosticsUiExt(),
 	});