#723 Fix PR nitpicks.

Author: yruslan

README.md

@@ -1952,7 +1952,7 @@ A: Update hadoop dll to version 3.2.2 or newer.
 
 ## Changelog
 - #### 2.9.8 will be released soon.
-  - [#723](https://github.com/AbsaOSS/cobrix/pull/723) Added the option to generate `corrupt_fields` field that contains field names and raw values
+  - [#723](https://github.com/AbsaOSS/cobrix/pull/723) Added the option to generate `_corrupt_fields` field that contains field names and raw values
     of fields that Cobrix couldn't decode.
     ```scala
     .option("generate_corrupt_fields", "true")

cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/ast/Primitive.scala

@@ -154,7 +154,8 @@ case class Primitive(
 
   /**
     * Checks if a value extracted from a given binary record at a specified offset is considered empty.
-    * A value is considered empty if it contains only null bytes or bytes equal to 0x40.
+    * A value is considered empty if it contains only null bytes or bytes equal to a space character
+    * of the underlying encoding (e.g., 0x40 for EBCDIC, 0x20 for ASCII, 0x00 for binary).
     *
     * @param itOffset The offset within the binary record where the value starts.
     * @param record   The binary record represented as an array of bytes.

cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/reader/extractors/record/RecordExtractors.scala

@@ -19,6 +19,7 @@ package za.co.absa.cobrix.cobol.reader.extractors.record
 import za.co.absa.cobrix.cobol.parser.CopybookParser.CopybookAST
 import za.co.absa.cobrix.cobol.parser.ast.datatype.{AlphaNumeric, COMP4}
 import za.co.absa.cobrix.cobol.parser.ast.{Group, Primitive, Statement}
+import za.co.absa.cobrix.cobol.parser.common.Constants
 import za.co.absa.cobrix.cobol.parser.encoding.RAW
 import za.co.absa.cobrix.cobol.reader.policies.SchemaRetentionPolicy
 import za.co.absa.cobrix.cobol.reader.policies.SchemaRetentionPolicy.SchemaRetentionPolicy
@@ -532,9 +533,9 @@ object RecordExtractors {
   private def getCorruptFieldsGroup: Group = {
     val corruptFieldsInGroup = new mutable.ArrayBuffer[Statement]
 
-    corruptFieldsInGroup += Primitive(15, "field_name", "field_name", 0, AlphaNumeric("X(50)", 50), decode = null, encode = null)(None)
-    corruptFieldsInGroup += Primitive(15, "raw_value", "raw_value", 0, AlphaNumeric("X(50)", 50, enc = Some(RAW), compact = Some(COMP4())), decode = null, encode = null)(None)
+    corruptFieldsInGroup += Primitive(15, Constants.fieldNameColumn, Constants.fieldNameColumn, 0, AlphaNumeric("X(50)", 50), decode = null, encode = null)(None)
+    corruptFieldsInGroup += Primitive(15, Constants.rawValueColumn, Constants.rawValueColumn, 0, AlphaNumeric("X(50)", 50, enc = Some(RAW), compact = Some(COMP4())), decode = null, encode = null)(None)
 
-    Group(10, "_corrupt_fields", "_corrupt_fields", 0,  children = corruptFieldsInGroup, occurs = Some(10))(None)
+    Group(10, Constants.corruptFieldsField, Constants.corruptFieldsField, 0,  children = corruptFieldsInGroup, occurs = Some(10))(None)
   }
 }

spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/CobolSchemaSpec.scala

@@ -906,7 +906,7 @@ class CobolSchemaSpec extends AnyWordSpec with SimpleComparisonBase {
       assert(sparkSchema.fields(0).name == "file_name")
       assert(sparkSchema.fields(1).name == "Seg_Id0")
       assert(sparkSchema.fields(2).name == "NUM1")
-      assert(sparkSchema.fields(2).dataType.isInstanceOf[StringType])
+      assert(sparkSchema.fields(2).dataType == StringType)
     }
   }
 }

spark-cobol/src/test/scala/za/co/absa/cobrix/spark/cobol/source/integration/Test41CorruptFieldsSpec.scala

@@ -102,7 +102,7 @@ class Test41CorruptFieldsSpec extends AnyWordSpec with SparkTestBase with Binary
           |""".stripMargin
 
       withTempBinFile("corrupt_fields1", ".dat", data) { tmpFileName =>
-        val df = getDataFrame(tmpFileName, Map("generate_corrupt_fields" -> "true"))
+        val df = getDataFrame(tmpFileName, Map(PARAM_CORRUPT_FIELDS -> "true"))
 
         val actualSchema = df.schema.treeString
         compareTextVertical(actualSchema, expectedSchema)
@@ -115,7 +115,7 @@ class Test41CorruptFieldsSpec extends AnyWordSpec with SparkTestBase with Binary
 
     "throw an exception when working with a hierarchical data" in {
       val ex = intercept[IllegalArgumentException] {
-        getDataFrame("/tmp/dummy", Map("generate_corrupt_fields" -> "true", "segment-children:0" -> "COMPANY => DEPT,CUSTOMER"))
+        getDataFrame("/tmp/dummy", Map(PARAM_CORRUPT_FIELDS -> "true", "segment-children:0" -> "COMPANY => DEPT,CUSTOMER"))
       }
 
       assert(ex.getMessage.contains(s"Option '$PARAM_CORRUPT_FIELDS=true' cannot be used with 'segment-children:*'"))