Commit 39cdbcb
authored
Merge: Use Custom instead of OHE encoded categorical parameter for Non-SHAP tests (emdgroup#732)
There seem to be machine-dependent non-deterministic failures for the
LIME method which is part of our SHAP insight (as non-SHAP extension
handled mostly via shap).
The failures do not indicate any particular problem on our side but some
internal process causing NaN's when calculating model regression
metrics. The test only seems to fail when there is the `Categorical_1`
parameter involved, which is a 3 category, OHE encoded parameter. This
was replaced with the custom parameter as it avoids degenerate values
which hopefully contribute to avoiding the NaN generations in LIME.
I've [tried this fix 3 times in the `Regular`
action](https://github.com/emdgroup/baybe/actions/runs/21355269316) (had
to ignore one pip-audit vulnerability to do so in a temporary commit
which has been removed again). All runs had no issue, which I take as
indication the fix worked. If the issue appears again I would probably
add another parameter to the test searchspaces to avoid generation of
degenerate points.2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
| 143 | + | |
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
| 58 | + | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
0 commit comments