Skip to content

Commit 72ce84f

Browse files
committed
Bugfix: critical error in max_event attr of detector file
1 parent f2799a4 commit 72ce84f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/attpc_engine/detector/writer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ def __init__(
173173
self.max_events_per_file: int = max_events_per_file
174174
self.run_number = first_run_number
175175
self.starting_event = 0 # Kinematics generator always starts with event 0
176+
self.last_event = 0 # What event number do we end on
176177
self.events_written = 0 # haven't written anything yet
177178
# initialize the first file
178179
path: Path = self.directory_path / f"run_{self.run_number:04d}.h5"
@@ -250,6 +251,7 @@ def write(
250251
_ = self.cloud_group.create_dataset(f"labels_{event_number}", data=labels)
251252

252253
# We wrote an event
254+
self.last_event = event_number
253255
self.events_written += 1
254256

255257
def set_number_of_events(self) -> None:
@@ -258,9 +260,7 @@ def set_number_of_events(self) -> None:
258260
Stores first and last event numbers in the attributes
259261
"""
260262
self.cloud_group.attrs["min_event"] = self.starting_event
261-
self.cloud_group.attrs["max_event"] = (
262-
self.starting_event + self.events_written - 1
263-
) # starting event counts towards number written
263+
self.cloud_group.attrs["max_event"] = self.last_event
264264

265265
def get_directory_name(self) -> Path:
266266
"""Returns directory that point cloud files are written to.

0 commit comments

Comments
 (0)