Skip to content

BUG: [Audit] Backend: Inconsistent password hashing and missing DB rollback logic #1244

@VaibhavKhokha

Description

@VaibhavKhokha

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

During a preliminary technical audit of the PictoPy backend for GSoC 2026, I identified two logical issues that could affect system stability:

Password Consistency: Empty strings are currently being hashed in some paths instead of being treated as None.

Transaction Integrity: The metadata write flow lacks a rollback() mechanism, which could lead to partial data writes if an execution fails.

I have already researched and prepared a fix for these issues to ensure production-grade reliability.

Note: I previously opened PR #1242 with the fixes. I am opening this issue now to follow the proper contribution workflow as requested by the mentor.

MyPy Scan Before Fixes (54 Errors):

Image

MyPy Scan After Fixes (49 Errors):

Image

Record

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions