Skip to content

fix(ci): install dotnet from global.json #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ANcpLua merged 1 commit into from
May 16, 2026
Merged

fix(ci): install dotnet from global.json #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Setup .NET 10
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Step name claims ".NET 10" but version now delegated to global.json.

If global.json specifies a different major version (e.g., 9.x or 11.x), the step name becomes misleading. Either verify global.json pins to 10.x or rename the step to reflect version delegation (e.g., "Setup .NET (from global.json)").

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 39, The workflow step named "Setup .NET 10"
is misleading because the actual SDK version is taken from global.json; rename
the step title string "Setup .NET 10" to something like "Setup .NET (from
global.json)" or update global.json to pin 10.x, and ensure any other references
to the step title are updated accordingly so the name accurately reflects where
the version is sourced.

Copy link
Copy Markdown

@codacy-production codacy-production Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: The step name 'Setup .NET 10' is now misleading because the SDK version is dynamically resolved from global.json. Consider renaming the step to a generic name like 'Setup .NET' or 'Setup .NET SDK' for better maintainability.

Suggested change
- name: Setup .NET 10
- name: Setup .NET

uses: actions/setup-dotnet@v5
with:
dotnet-version: 10.0.x
global-json-file: global.json

- name: Cache NuGet packages
uses: actions/cache@v5
Expand Down
Loading