Skip to content

Commit d735a8f

Browse files
ANcpLuaclaude
andcommitted
fix: correct polyfill paths in nuspec, remove dead code
Lock.cs and DiagnosticClasses.cs were packed to shared/Polyfills/ but LegacySupport.targets references shared/MSBuild/Polyfills/. Align nuspec targets across all three SDK variants. Remove obsolete TrimAttributes.cs, Compiler.cs, and eng/ directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f28db1a commit d735a8f

File tree

14 files changed

+26
-242
lines changed

14 files changed

+26
-242
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
$PreviousTag = git describe --tags --abbrev=0 2>$null
126126
if ($PreviousTag) {
127127
Write-Host "Previous tag: $PreviousTag"
128-
$Changes = git diff --name-only $PreviousTag HEAD -- '*.nuspec' 'src/**/*' 'eng/**/*'
128+
$Changes = git diff --name-only $PreviousTag HEAD -- '*.nuspec' 'src/**/*'
129129
} else {
130130
Write-Host "No previous tag found, checking all files"
131131
$Changes = $true

.github/workflows/trigger-docs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
branches: [main]
55
paths:
66
- 'src/**'
7-
- 'eng/**'
87
- 'README.md'
98
release:
109
types: [published]

ANcpLua.NET.Sdk.slnx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@
2020
<Project Path="src/ANcpLua.NET.Sdk.Test.csproj" />
2121
</Folder>
2222

23-
<!-- Engineering (Polyfills, Extensions, Shared) -->
24-
<Folder Name="/eng/">
25-
<File Path="eng/CLAUDE.md" />
26-
<File Path="eng/Directory.Build.props" />
27-
</Folder>
2823
<!-- Tests -->
2924
<Folder Name="/tests/">
3025
<Project Path="tests/ANcpLua.Sdk.Tests/ANcpLua.Sdk.Tests.csproj" />

eng/CLAUDE.md

Lines changed: 0 additions & 33 deletions
This file was deleted.

eng/Directory.Build.props

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/ANcpLua.NET.Sdk.Test.nuspec

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,11 @@
8282
<file src="shared/Polyfills/Exceptions/UnreachableException.cs" target="shared/Polyfills/Exceptions/"/>
8383
<file src="shared/Polyfills/Experimental/ExperimentalAttribute.cs" target="shared/Polyfills/Experimental/"/>
8484
<file src="shared/Polyfills/TimeProvider/TimeProvider.cs" target="shared/Polyfills/TimeProvider/"/>
85-
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/Polyfills/"/>
86-
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/Polyfills/"/>
87-
<file src="shared/MSBuild/Polyfills/TrimAttributes.cs" target="shared/Polyfills/"/>
88-
85+
<file src="shared/Polyfills/StringExtensions/StringExtensions.cs" target="shared/Polyfills/StringExtensions/"/>
86+
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/MSBuild/Polyfills/"/>
87+
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/MSBuild/Polyfills/"/>
8988
<!-- Shared Sources - Other -->
9089
<file src="shared/Throw/Throw.cs" target="shared/Throw/"/>
91-
<file src="shared/CodeTests/Compiler.cs" target="shared/CodeTests/"/>
9290
<file src="shared/Extensions/Comparers/StringOrdinalComparer.cs" target="shared/Extensions/Comparers/"/>
9391
<file src="shared/Extensions/CodeFixes/CodeFixProviderBase.cs" target="shared/Extensions/CodeFixes/"/>
9492
<file src="shared/Extensions/DiagnosticAnalyzerBase.cs" target="shared/Extensions/"/>

src/ANcpLua.NET.Sdk.Web.nuspec

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@
5656
<file src="Config/BannedSymbols.NewtonsoftJson.txt" target="Config/"/>
5757
<file src="Config/default.runsettings" target="Config/"/>
5858

59-
<!-- Testing - only in .Test SDK -->
60-
<file src="Testing/Testing.props" target="Testing/"/>
61-
6259
<!-- Shared Sources - Polyfills -->
6360
<file src="shared/Polyfills/IndexRange/Index.cs" target="shared/Polyfills/IndexRange/"/>
6461
<file src="shared/Polyfills/IndexRange/Range.cs" target="shared/Polyfills/IndexRange/"/>
@@ -79,13 +76,11 @@
7976
<file src="shared/Polyfills/Exceptions/UnreachableException.cs" target="shared/Polyfills/Exceptions/"/>
8077
<file src="shared/Polyfills/Experimental/ExperimentalAttribute.cs" target="shared/Polyfills/Experimental/"/>
8178
<file src="shared/Polyfills/TimeProvider/TimeProvider.cs" target="shared/Polyfills/TimeProvider/"/>
82-
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/Polyfills/"/>
83-
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/Polyfills/"/>
84-
<file src="shared/MSBuild/Polyfills/TrimAttributes.cs" target="shared/Polyfills/"/>
85-
79+
<file src="shared/Polyfills/StringExtensions/StringExtensions.cs" target="shared/Polyfills/StringExtensions/"/>
80+
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/MSBuild/Polyfills/"/>
81+
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/MSBuild/Polyfills/"/>
8682
<!-- Shared Sources - Other -->
8783
<file src="shared/Throw/Throw.cs" target="shared/Throw/"/>
88-
<file src="shared/CodeTests/Compiler.cs" target="shared/CodeTests/"/>
8984
<file src="shared/Extensions/Comparers/StringOrdinalComparer.cs" target="shared/Extensions/Comparers/"/>
9085
<file src="shared/Extensions/CodeFixes/CodeFixProviderBase.cs" target="shared/Extensions/CodeFixes/"/>
9186
<file src="shared/Extensions/DiagnosticAnalyzerBase.cs" target="shared/Extensions/"/>

src/ANcpLua.NET.Sdk.nuspec

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,10 @@
8080
<file src="shared/Polyfills/Experimental/ExperimentalAttribute.cs" target="shared/Polyfills/Experimental/"/>
8181
<file src="shared/Polyfills/TimeProvider/TimeProvider.cs" target="shared/Polyfills/TimeProvider/"/>
8282
<file src="shared/Polyfills/StringExtensions/StringExtensions.cs" target="shared/Polyfills/StringExtensions/"/>
83-
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/Polyfills/"/>
84-
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/Polyfills/"/>
85-
<file src="shared/MSBuild/Polyfills/TrimAttributes.cs" target="shared/Polyfills/"/>
86-
83+
<file src="shared/MSBuild/Polyfills/DiagnosticClasses.cs" target="shared/MSBuild/Polyfills/"/>
84+
<file src="shared/MSBuild/Polyfills/Lock.cs" target="shared/MSBuild/Polyfills/"/>
8785
<!-- Shared Sources - Other -->
8886
<file src="shared/Throw/Throw.cs" target="shared/Throw/"/>
89-
<file src="shared/CodeTests/Compiler.cs" target="shared/CodeTests/"/>
9087
<file src="shared/Extensions/Comparers/StringOrdinalComparer.cs" target="shared/Extensions/Comparers/"/>
9188
<file src="shared/Extensions/CodeFixes/SyntaxModifierExtensions.cs" target="shared/Extensions/CodeFixes/"/>
9289
<file src="shared/Extensions/CodeFixes/CodeFixProviderBase.cs" target="shared/Extensions/CodeFixes/"/>

src/Build/Common/LegacySupport.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
<InjectLockPolyfill Condition="'$(InjectLockPolyfill)' == ''">false</InjectLockPolyfill>
5454
<InjectTimeProviderPolyfill Condition="'$(InjectTimeProviderPolyfill)' == ''">false</InjectTimeProviderPolyfill>
5555
<InjectStringExtensionsPolyfill Condition="'$(InjectStringExtensionsPolyfill)' == ''">false</InjectStringExtensionsPolyfill>
56+
<InjectDiagnosticClassesOnLegacy Condition="'$(InjectDiagnosticClassesOnLegacy)' == ''">false</InjectDiagnosticClassesOnLegacy>
5657

5758
<!-- ANcpLua Polyfills - default to false - opt-in -->
5859
<InjectANcpLuaDiagnosticsPolyfills Condition="'$(InjectANcpLuaDiagnosticsPolyfills)' == ''">false</InjectANcpLuaDiagnosticsPolyfills>

src/Build/Common/LegacySupport.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
<InjectANcpLuaNullabilityPolyfills>true</InjectANcpLuaNullabilityPolyfills>
3535
<InjectANcpLuaTimeProviderPolyfill>true</InjectANcpLuaTimeProviderPolyfill>
3636
<InjectANcpLuaTrimAttributesPolyfills>true</InjectANcpLuaTrimAttributesPolyfills>
37+
<InjectDiagnosticClassesOnLegacy>true</InjectDiagnosticClassesOnLegacy>
3738
</PropertyGroup>
3839

3940
<PropertyGroup Condition="'$(InjectAllExtensions)' == 'true'">

0 commit comments

Comments
 (0)