fix(coderabbit): use minimatch path globs#160
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
@coderabbitai autofix |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
While the PR successfully converts brace-expanded path globs into individual entries, it introduces a significant regression in the review instructions for MSBuild and project metadata files. Specifically, instructions for .props, .targets, .csproj, and .sln files now incorrectly share the same rules as C# source code, resulting in the loss of previous architectural checks (like TargetFrameworks and analyzer versions) and the inclusion of irrelevant C# logic checks (like async flow and CancellationToken). Codacy analysis currently reports the PR as up to standards, but these logic regressions should be addressed before merging.
About this PR
- The expansion of path globs led to the loss of specialized instructions for MSBuild .props files (previously targeting TargetFrameworks and analyzer versions). These were replaced by generic C# code instructions which are not applicable to the MSBuild XML schema.
Test suggestions
- Verify .cs, .csproj, .props, .targets, .sln, and .slnx paths are individually defined.
- Verify .md and .mdx paths are individually defined with documentation instructions.
- Verify generated file extensions (.g.cs, .g.ts, etc.) are individually defined with generated-output instructions.
- Confirm LanguageTool level is set to 'default'.
- Ensure TypeScript and TSX files are individually defined in the code_generation sections.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| - "!**/*.trx" | ||
| path_instructions: | ||
| - path: "**/*.{cs,csproj,props,targets,sln,slnx}" | ||
| - path: "**/*.cs" |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The instructions for project (.csproj), property (.props), target (.targets), and solution (.sln, .slnx) files are currently identical to the C# source code instructions, leading to two main issues:
- Regression: Specific guidance for MSBuild property files (previously regarding
TargetFrameworks,Microsoft.CodeAnalysisversions, andIsRoslynComponentflags) has been lost. - Irrelevance: Rules for
asyncflow,DateTime.Now, andCancellationTokenare not applicable to XML project files or solution metadata and will likely generate noise.
Try running the following prompt in your IDE agent:
Update the
.coderabbit.yamlfile to provide relevant instructions for non-C# files. For**/*.propsand**/*.targets, restore the guidance regarding TargetFrameworks and analyzer versions. For**/*.csproj,**/*.sln, and**/*.slnx, remove C#-specific logic checks and focus on project/solution metadata integrity.
| languagetool: | ||
| enabled: true | ||
| level: picky | ||
| level: default |
There was a problem hiding this comment.
⚪ LOW RISK
Nitpick: The languagetool level was changed from picky to default, which reduces the depth of grammar and style checks. If this was intended to reduce noise, it is acceptable, but it should be noted as it is a behavioral change unrelated to the glob pattern refactoring.
What changed
Validation
.coderabbit.yamlfrom the schema-backed generator..coderabbit.yamlagainst the live CodeRabbit v2 schema.{...}brace glob patterns before pushing.