Skip to content

fix(coderabbit): use minimatch path globs#160

Merged
github-actions[bot] merged 1 commit into
mainfrom
dev/coderabbit-proplus-minimatch-20260516160708
May 16, 2026
Merged

fix(coderabbit): use minimatch path globs#160
github-actions[bot] merged 1 commit into
mainfrom
dev/coderabbit-proplus-minimatch-20260516160708

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented May 16, 2026

What changed

  • Replace brace-expanded CodeRabbit path globs with explicit minimatch-compatible path entries.
  • Keep generated-output and lockfile review enabled from the previous follow-up.
  • Keep LanguageTool enabled but use the default level to avoid contradicting the no-style-only-nits review posture.

Validation

  • Regenerated .coderabbit.yaml from the schema-backed generator.
  • Validated .coderabbit.yaml against the live CodeRabbit v2 schema.
  • Checked the generated YAML for remaining {...} brace glob patterns before pushing.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@ANcpLua has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 450f9f61-e6ae-49a6-a4a1-896542a3a185

📥 Commits

Reviewing files that changed from the base of the PR and between cf35896 and 663f663.

📒 Files selected for processing (1)
  • .coderabbit.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/coderabbit-proplus-minimatch-20260516160708
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch dev/coderabbit-proplus-minimatch-20260516160708
  • 🛠️ architecture hardening
  • 🛠️ security pass
  • 🛠️ test gap closure
  • 🛠️ docs and changelog alignment
  • 🛠️ performance and allocation pass

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot enabled auto-merge (squash) May 16, 2026 14:07
@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@claude
Copy link
Copy Markdown

claude Bot commented May 16, 2026

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the PR successfully converts brace-expanded path globs into individual entries, it introduces a significant regression in the review instructions for MSBuild and project metadata files. Specifically, instructions for .props, .targets, .csproj, and .sln files now incorrectly share the same rules as C# source code, resulting in the loss of previous architectural checks (like TargetFrameworks and analyzer versions) and the inclusion of irrelevant C# logic checks (like async flow and CancellationToken). Codacy analysis currently reports the PR as up to standards, but these logic regressions should be addressed before merging.

About this PR

  • The expansion of path globs led to the loss of specialized instructions for MSBuild .props files (previously targeting TargetFrameworks and analyzer versions). These were replaced by generic C# code instructions which are not applicable to the MSBuild XML schema.

Test suggestions

  • Verify .cs, .csproj, .props, .targets, .sln, and .slnx paths are individually defined.
  • Verify .md and .mdx paths are individually defined with documentation instructions.
  • Verify generated file extensions (.g.cs, .g.ts, etc.) are individually defined with generated-output instructions.
  • Confirm LanguageTool level is set to 'default'.
  • Ensure TypeScript and TSX files are individually defined in the code_generation sections.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread .coderabbit.yaml
- "!**/*.trx"
path_instructions:
- path: "**/*.{cs,csproj,props,targets,sln,slnx}"
- path: "**/*.cs"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The instructions for project (.csproj), property (.props), target (.targets), and solution (.sln, .slnx) files are currently identical to the C# source code instructions, leading to two main issues:

  1. Regression: Specific guidance for MSBuild property files (previously regarding TargetFrameworks, Microsoft.CodeAnalysis versions, and IsRoslynComponent flags) has been lost.
  2. Irrelevance: Rules for async flow, DateTime.Now, and CancellationToken are not applicable to XML project files or solution metadata and will likely generate noise.

Try running the following prompt in your IDE agent:

Update the .coderabbit.yaml file to provide relevant instructions for non-C# files. For **/*.props and **/*.targets, restore the guidance regarding TargetFrameworks and analyzer versions. For **/*.csproj, **/*.sln, and **/*.slnx, remove C#-specific logic checks and focus on project/solution metadata integrity.

Comment thread .coderabbit.yaml
languagetool:
enabled: true
level: picky
level: default
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: The languagetool level was changed from picky to default, which reduces the depth of grammar and style checks. If this was intended to reduce noise, it is acceptable, but it should be noted as it is a behavioral change unrelated to the glob pattern refactoring.

@github-actions github-actions Bot merged commit 78347f4 into main May 16, 2026
10 of 11 checks passed
@ANcpLua ANcpLua deleted the dev/coderabbit-proplus-minimatch-20260516160708 branch May 16, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant