Skip to content

Hygiene pass: 8-PR cleanup tracking issue #71

@Moeabdelaziz007

Description

@Moeabdelaziz007

Tracking issue for a focused hygiene pass on IQRA based on a code-review audit. Each item below ships as its own PR per the scope discipline in AGENTS.md (one concern per PR, no bundled changes).

The 8 PRs

  1. chore(root): remove build artifacts and scratch files
    Delete `....`, `.kiro`, `ts_errors.txt`, `tsc_output.txt`, `tsconfig.json.backup`, `bin/iqra-engine` (9MB Go binary), `debug_brain.ts`, `scratch_debug.ts`, `scratch/`, `docs-out/index.html`. Extend `.gitignore` to prevent recurrence.

  2. fix(paths): replace absolute /Applications/iqra/ paths with portable ones
    Replaces 3 broken file:// links in `IQRA_SUPREME.md` (sovereign file, this PR carries explicit maintainer approval recorded here) and 3 hardcoded mission paths in `src/tests/e2e/10_serendipity_exploration.e2e.ts`. Tests currently only run on the maintainer's macOS box.

  3. chore(layers): resolve layer-08 collision
    `src/lib/iqra/08-cognitive/` and `src/lib/iqra/08-skills/` both occupy slot 08. Per the architectural decision in 🧪 add unit test for iqraGraph #4, the `08-skills/` slot becomes a marketplace adapter rather than a local skill catalogue, so this PR removes the local `08-skills/` shell and keeps `08-cognitive/`.

  4. feat(aix): wire IQRA skills layer to the aix-agent-skills marketplace
    `#skills/git_skill`, `#skills/inverse_design`, and friends are referenced but missing. Architectural decision: IQRA (L2) consumes skills from `aix-agent-skills` (L3) rather than maintaining a local catalogue. This PR adds a `src/lib/iqra/14-aix/marketplace_loader.ts` that loads skill definitions by id from the L3 marketplace, and replaces the broken `#skills/*` imports with marketplace calls.

  5. chore(constitution): populate or deprecate iqra-core/
    `iqra-core/` is declared as the active runtime manifest in AGENTS.md but contains only `METAMORPHOSIS.md`. Decision pending: either repopulate from `src/lib/iqra/00-manifest/` or update AGENTS.md to acknowledge `00-manifest/` as the canonical source and mark `iqra-core/` historical.

  6. chore(ratchet): lower TS error baseline from 383 to 300
    The Ratchet Effect pre-commit hook (`.husky/pre-commit`) caps TS errors at 383. Many errors are direct consequences of 🧪 add unit test for iqraGraph #4 (missing modules). After 🧪 add unit test for iqraGraph #4 lands, fix the residual ~80 errors that don't depend on the marketplace, and reset the baseline.

  7. fix(integrity): remove mock data triggers from core paths
    `FAILURES.md` repeatedly logs `MITHAQ_VIOLATION: Mock data detected in core logic` even though "No Mocks" is a sovereign rule. Find and remove the actual mocks the integrity scanner is detecting.

  8. chore(failures): add resolution status to FAILURES.md entries
    The current schema is `{Date, Failure, Root Cause, Recovery Action}` but no closure field, so the same failure types repeat without anyone marking them resolved. Add a `status: open|resolved` field and a tooling rule that requires resolution within N cycles.

Approval

The repo owner approved this plan in the conversation that generated this issue. PRs 2 and 5 touch sovereign files (IQRA_SUPREME.md, iqra-core/) and AGENTS.md flags those as requiring explicit human approval; this issue is that approval.

Scope guarantees

  • Each PR stays under the 1000-line soft cap from AGENTS.md.
  • No PR bundles a "while I'm here" cleanup.
  • Sovereign files are not touched outside PR 2 and PR 5.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions