From 659513d665e7a83bb240db288c0492699e888b72 Mon Sep 17 00:00:00 2001 From: Yixuan Mei <30572462+AntonyMei@users.noreply.github.com> Date: Wed, 1 Jul 2026 17:26:25 -0700 Subject: [PATCH] Remove stale Tunix degenerate group masking config --- src/maxtext/configs/post_train/rl.yml | 2 -- src/maxtext/configs/types.py | 4 ---- src/maxtext/trainers/post_train/rl/train_rl.py | 1 - 3 files changed, 7 deletions(-) diff --git a/src/maxtext/configs/post_train/rl.yml b/src/maxtext/configs/post_train/rl.yml index 3ecdd3b981..5eb63c6208 100644 --- a/src/maxtext/configs/post_train/rl.yml +++ b/src/maxtext/configs/post_train/rl.yml @@ -66,8 +66,6 @@ rl: off_policy_steps: 0 # System prompt injected into the agent at rollout time. system_prompt: '' - # If true, mask degenerate groups (all-zero advantages) from contributing to the loss. - degenerate_group_masking: true # Upper-bound clipping epsilon for GRPO loss; defaults to grpo_epsilon when null. epsilon_high: null # Number of model keys to chunk for resharding tensors between trainer and rollout devices. diff --git a/src/maxtext/configs/types.py b/src/maxtext/configs/types.py index 769a8c1745..73b7ba70f8 100644 --- a/src/maxtext/configs/types.py +++ b/src/maxtext/configs/types.py @@ -2156,10 +2156,6 @@ class RL(BaseModel): "", description="System prompt injected into the agent at rollout time (agentic only).", ) - degenerate_group_masking: bool = Field( - True, - description="Mask degenerate groups (all-zero advantages) from contributing to loss (agentic only).", - ) epsilon_high: Optional[float] = Field( None, description="Upper-bound clipping epsilon for GRPO loss. Defaults to epsilon when None (agentic only).", diff --git a/src/maxtext/trainers/post_train/rl/train_rl.py b/src/maxtext/trainers/post_train/rl/train_rl.py index bd60747aeb..66a9bd858b 100644 --- a/src/maxtext/trainers/post_train/rl/train_rl.py +++ b/src/maxtext/trainers/post_train/rl/train_rl.py @@ -555,7 +555,6 @@ def _reward_fn(**kwargs): max_concurrency=trainer_config.rl.max_concurrency, off_policy_steps=trainer_config.rl.off_policy_steps, system_prompt=trainer_config.rl.system_prompt, - degenerate_group_masking=trainer_config.rl.degenerate_group_masking, epsilon_high=trainer_config.rl.epsilon_high, ) # Instantiate the custom MaxText chat parser