Skip to content

Commit bb8fe56

Browse files
authored
Merge pull request #68 from 38degrees/revert-ruby-3-3-5-change
Revert "Merge pull request #67 from 38degrees/upgrade-to-ruby-3-3-5"
2 parents 0ba8ba7 + 749ac9e commit bb8fe56

6 files changed

Lines changed: 54 additions & 31 deletions

File tree

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@
44

55
version: 2.1
66
orbs:
7-
ruby: circleci/ruby@2.2.1
7+
ruby: circleci/ruby@1.1.1
88
jobs:
99
build:
1010
docker:
11-
- image: cimg/ruby:3.3.5-browsers
11+
- image: circleci/ruby:3.0.0-node-browsers
1212
environment:
1313
- RACK_ENV=test
1414
- RAILS_ENV=test
1515
- DATABASE_URL=postgres://testuser:testpass@127.0.0.1:5432/mahbucket_test
1616
- SKIP_AUTH=true
1717

18-
- image: cimg/postgres:10.20
18+
- image: circleci/postgres:10-alpine-ram
1919
environment:
2020
- POSTGRES_USER=testuser
2121
- POSTGRES_PASSWORD=testpass

Dockerfile

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# This Dockerfile uses a circleci image for convenience.
2+
3+
FROM circleci/ruby:3.0.0-node-browsers
4+
5+
USER root
6+
RUN mkdir /app
7+
WORKDIR /app
8+
9+
# As this is a dev container we are keeping the installation of app
10+
# dependencies (via bundle and yarn), and the mounting of the source
11+
# code external to the container build
12+
#ENV PATH="/usr/local/lib/ruby/gems/bin:${PATH}"
13+
RUN mkdir /bundle
14+
ENV BUNDLE_PATH=/bundle
15+
ENV GEM_HOME=/bundle
16+
RUN bundle config set path '/bundle'
17+
18+
RUN mkdir -p /tmp/sockets
19+
20+
CMD bundle check || bundle install && bundle exec puma -C ./config/puma.rb

Gemfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ruby "3.3.5"
1+
ruby "3.0.0"
22

33
source 'https://rubygems.org' do
44
gem 'rails', '~> 6.1.7'
@@ -80,5 +80,6 @@ source 'https://rubygems.org' do
8080
gem 'rspec'
8181
gem 'rspec_junit_formatter'
8282
gem 'selenium-webdriver'
83+
gem 'webdrivers', '~> 4.4'
8384
end
8485
end

Gemfile.lock

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ GEM
7272
zeitwerk (~> 2.3)
7373
acts-as-taggable-on (9.0.1)
7474
activerecord (>= 6.0, < 7.1)
75-
addressable (2.8.7)
76-
public_suffix (>= 2.0.2, < 7.0)
75+
addressable (2.8.1)
76+
public_suffix (>= 2.0.2, < 6.0)
7777
ast (2.4.2)
7878
aws-eventstream (1.2.0)
7979
aws-partitions (1.720.0)
@@ -91,17 +91,16 @@ GEM
9191
aws-sigv4 (~> 1.4)
9292
aws-sigv4 (1.5.2)
9393
aws-eventstream (~> 1, >= 1.0.2)
94-
base64 (0.2.0)
9594
brakeman (5.4.1)
9695
builder (3.2.4)
9796
bundler-audit (0.9.1)
9897
bundler (>= 1.2.0, < 3)
9998
thor (~> 1.0)
100-
capybara (3.40.0)
99+
capybara (3.38.0)
101100
addressable
102101
matrix
103102
mini_mime (>= 0.1.3)
104-
nokogiri (~> 1.11)
103+
nokogiri (~> 1.8)
105104
rack (>= 1.6.0)
106105
rack-test (>= 0.6.3)
107106
regexp_parser (>= 1.5, < 3.0)
@@ -172,7 +171,6 @@ GEM
172171
listen (3.8.0)
173172
rb-fsevent (~> 0.10, >= 0.10.3)
174173
rb-inotify (~> 0.9, >= 0.9.10)
175-
logger (1.6.1)
176174
loofah (2.21.3)
177175
crass (~> 1.0.2)
178176
nokogiri (>= 1.12.0)
@@ -187,8 +185,8 @@ GEM
187185
mime-types (3.4.1)
188186
mime-types-data (~> 3.2015)
189187
mime-types-data (3.2023.0218.1)
190-
mini_mime (1.1.5)
191-
mini_portile2 (2.8.8)
188+
mini_mime (1.1.2)
189+
mini_portile2 (2.8.5)
192190
minitest (5.18.1)
193191
multi_xml (0.6.0)
194192
net-imap (0.3.6)
@@ -202,10 +200,10 @@ GEM
202200
net-protocol
203201
newrelic_rpm (9.0.0)
204202
nio4r (2.7.3)
205-
nokogiri (1.16.7)
203+
nokogiri (1.16.2)
206204
mini_portile2 (~> 2.8.2)
207205
racc (~> 1.4)
208-
nokogiri (1.16.7-x86_64-linux)
206+
nokogiri (1.16.2-x86_64-linux)
209207
racc (~> 1.4)
210208
oauth2 (2.0.9)
211209
faraday (>= 0.17.3, < 3.0)
@@ -238,11 +236,11 @@ GEM
238236
method_source (~> 1.0)
239237
pry-rails (0.3.9)
240238
pry (>= 0.10.4)
241-
public_suffix (6.0.1)
239+
public_suffix (5.0.1)
242240
puma (5.6.9)
243241
nio4r (~> 2.0)
244-
racc (1.8.1)
245-
rack (2.2.10)
242+
racc (1.7.3)
243+
rack (2.2.7)
246244
rack-protection (3.0.5)
247245
rack
248246
rack-test (2.1.0)
@@ -285,9 +283,9 @@ GEM
285283
rb-fsevent (0.11.2)
286284
rb-inotify (0.10.1)
287285
ffi (~> 1.0)
288-
regexp_parser (2.9.3)
286+
regexp_parser (2.7.0)
289287
repost (0.4.1)
290-
rexml (3.3.9)
288+
rexml (3.2.5)
291289
rspec (3.12.0)
292290
rspec-core (~> 3.12.0)
293291
rspec-expectations (~> 3.12.0)
@@ -350,9 +348,7 @@ GEM
350348
sprockets (> 3.0)
351349
sprockets-rails
352350
tilt
353-
selenium-webdriver (4.27.0)
354-
base64 (~> 0.2)
355-
logger (~> 1.4)
351+
selenium-webdriver (4.8.1)
356352
rexml (~> 3.2, >= 3.2.5)
357353
rubyzip (>= 1.2.2, < 3.0)
358354
websocket (~> 1.0)
@@ -391,7 +387,11 @@ GEM
391387
execjs (>= 0.3.0, < 3)
392388
unicode-display_width (2.4.2)
393389
version_gem (1.1.1)
394-
websocket (1.2.11)
390+
webdrivers (4.7.0)
391+
nokogiri (~> 1.6)
392+
rubyzip (>= 1.3.0)
393+
selenium-webdriver (> 3.141, < 5.0)
394+
websocket (1.2.9)
395395
websocket-driver (0.7.5)
396396
websocket-extensions (>= 0.1.0)
397397
websocket-extensions (0.1.5)
@@ -442,9 +442,10 @@ DEPENDENCIES
442442
sentry-ruby!
443443
turbolinks!
444444
uglifier!
445+
webdrivers (~> 4.4)!
445446

446447
RUBY VERSION
447-
ruby 3.3.5p100
448+
ruby 3.0.0p0
448449

449450
BUNDLED WITH
450-
2.5.23
451+
2.2.17

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ should hopefully be useful (or at least usable) for other file types too.
1010
## Ruby and Rails versions
1111

1212
Mah Bucket was initially developed using Ruby 2.3.1 and Rails 5.0.1, and is
13-
currently using Ruby 3.3.5 and Rails ~>6.1.7 - so it should have a fairly wide
13+
currently using Ruby 2.7.1 and Rails 6.0.3 - so it should have a fairly wide
1414
compatibility range. If you find a version of either that it won't run with,
1515
please let me know.
1616

docker-compose.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: '3'
33
x-service-fragments:
44
##### Abstract services for common setup #####
55
app: &app
6-
image: cimg/ruby:3.3.5-browsers
6+
image: ruby
77
networks:
88
- default
99
volumes:
@@ -19,7 +19,7 @@ x-service-fragments:
1919
services:
2020
##### Concrete services #####
2121
postgres:
22-
image: 'cimg/postgres:10.20'
22+
image: 'postgres:9.6-alpine'
2323
environment:
2424
# The Postgres image uses these to create a db user - note the user/pass here should match that in your env file!
2525
- POSTGRES_USER=user
@@ -30,9 +30,9 @@ services:
3030

3131
web:
3232
<<: *app
33-
volumes:
34-
- '.:/usr/src/app:cached'
35-
working_dir: /usr/src/app
33+
build:
34+
dockerfile: Dockerfile
35+
context: .
3636
ports:
3737
# Use a default port of 3005, but allow it to be overriden by an env variable
3838
# E.g. `PORT=3001 docker-compose up`
@@ -49,6 +49,7 @@ services:
4949
- SKIP_AUTH=true
5050
command: sh -c 'bundle check || bundle install && rm -f /tmp/.X99-lock && bundle exec rails db:create db:environment:set db:schema:load && bundle exec rubocop && bundle exec rspec && bundle exec puma -C ./config/puma.rb'
5151

52+
5253
volumes:
5354
postgres:
5455
bundle_cache:

0 commit comments

Comments
 (0)