Schema validation in the issuer node is not providing clear error messages

[roderik]

Expected behaviour

Credential is issued

Actual behaviour

time=2024-06-12T14:09:32.439Z level=ERROR msg="validating credential subject" err="protected term redefinition: invalid JSON-LD syntax; tried to redefine a protected term"
time=2024-06-12T14:09:32.439Z level=ERROR msg="error saving the link" err="cannot parse claim"

Steps to reproduce the problem

I created the following credential via the public credential designer: https://schema-builder.polygonid.me/schemas/bbf8da01-b417-4349-84bb-eec622dc1d57

I can import it into the issuer (public and self managed), but when i try to issue it I get the error above (error 400 in the browser)

System information

Issuer node version: 0xpolygon/issuernode:7e0c661
OS & Version: k8s amd64
Browser & Version: Chrome/Safari

Logs (if needed)

time=2024-06-12T14:09:32.439Z level=ERROR msg="validating credential subject" err="protected term redefinition: invalid JSON-LD syntax; tried to redefine a protected term"
time=2024-06-12T14:09:32.439Z level=ERROR msg="error saving the link" err="cannot parse claim"

When submitting logs, please submit them as text and not as screenshots.

[roderik]

Ok, so it is not possible to call a field "issuer". It would be best to prevent this in the UI.

[ottomorac]

I see yes. This error would apply to both the issuer node and the schema builder I agree. We need better error messages.

[amonsosanz]

Thx for the report @roderik. I see 2 issues here:

1. The issuer node should not allow importing invalid schemas
2. The schema builder should not allow building invalid schemas

We will review the list of reserved words, make sure they are consistent in both tools, and consider them when importing a schema in the issuer node.

[amonsosanz]

We just fixed this in the Schema Builder. We added some other missing reserved words along with issuer.

Regarding the import of invalid schemas in the issuer node, we created an internal task that will be prioritized and eventually implemented. I suggest that we leave this issue open until this is fixed and released.

[ottomorac]

Thank you @amonsosanz for the update!

[github-actions]

This issue is stale because it has been open 20 days with no activity. Remove stale label, add the enhancement label or comment to avoid closing it in 10 days.